Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes non streaming OrderByCrossPartitionQueryPipelineStage to remove state and handle splits #4493

Conversation

neildsh
Copy link
Contributor

@neildsh neildsh commented May 14, 2024

Description

Simplifies OrderByCrossPartitionQueryPipelineStage to remove state and be a static class. Since we can now statically detect no streaming order by queries, the OrderByCrossPartitionQueryPipelineStage can be simplified considerably.

We also add more handling for splits/merges for the non streaming order by pipeline stage.

Improve test coverage for split/merge handling as well as stronger validation for query charges.

Related changes:
#4362 , #4446, #4459, #4492

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@neildsh neildsh force-pushed the users/ndeshpan/simplifynonStreamingOrderBy branch from 976be02 to 01ae3d6 Compare May 16, 2024 19:49
sboshra
sboshra previously approved these changes May 16, 2024
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@neildsh neildsh added QUERY auto-merge Enables automation to merge PRs labels May 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d5f17f2 into master May 17, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/ndeshpan/simplifynonStreamingOrderBy branch May 17, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants