-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Fixes non streaming order by to use flag from query plan #4459
Merged
microsoft-github-policy-service
merged 2 commits into
master
from
users/ndeshpan/nonStreamingOrderByQueryPlan
Apr 29, 2024
Merged
Query: Fixes non streaming order by to use flag from query plan #4459
microsoft-github-policy-service
merged 2 commits into
master
from
users/ndeshpan/nonStreamingOrderByQueryPlan
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_streaming in the response
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
April 29, 2024 18:31
adityasa
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sc978345
reviewed
Apr 29, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
sboshra
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/nonStreamingOrderByQueryPlan
branch
April 29, 2024 21:17
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The contract with the backend for non streaming order by has changed. The backend response will no longer have _streaming. Instead there is a new flag on the query plan to indicate the presence of a non streaming order by. This PR switches non streaming order by to use flag from query plan instead of _streaming in the backend response.
This PR does not do any code cleanup, since the SDK is required for integration testing of the backend. The cleanup PR will follow this change.
Type of change