-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Adds an environment config to suppress sending NonStreamingOrderBy in the list of query features sent to the gateway #4492
Merged
microsoft-github-policy-service
merged 3 commits into
master
from
users/ndeshpan/nonStreamingOrderByEnvVar
May 15, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…By in the list of query features sent to the gateway
adityasa
reviewed
May 14, 2024
adityasa
reviewed
May 14, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/CosmosQueryExecutionContextFactory.cs
Show resolved
Hide resolved
adityasa
reviewed
May 14, 2024
adityasa
reviewed
May 14, 2024
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
May 14, 2024
Microsoft.Azure.Cosmos/src/RequestOptions/QueryRequestOptions.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
May 14, 2024
...ure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/NonStreamingOrderByQueryTests.cs
Outdated
Show resolved
Hide resolved
adityasa
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…suppression environment variable for the test pipeline since we run against an old emulator
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sboshra
reviewed
May 14, 2024
Microsoft.Azure.Cosmos/src/Query/Core/QueryPlan/QueryPlanRetriever.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
May 14, 2024
sboshra
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sboshra
approved these changes
May 15, 2024
khdang
approved these changes
May 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to retrieve a query plan for non streaming order by queries, the sdk must send NonStreamingOrderBy in the list of supported query features to the gateway. However, older gateways will not recognize this new value, causing the query plan request to fail with a 400. To mitigate this edge case, we add a check for an environment variable
AZURE_COSMOS_NON_STREAMING_ORDER_BY_FLAG_DISABLED
, which when set toTrue
will suppress sending NonStreamingOrderBy in the list of supported query features.A note about the naming
It is named as
DISABLED
by design for two reasons:false
be the default for boolean flags. (Since C# will auto initialize to false for members.) If we name the flag asENABLED
, the default value would have to betrue
Type of change