Skip to content

Adding missing package_data entries#9760

Merged
tjprescott merged 5 commits intoAzure:FixTestDiscoveryfrom
marstr:add_package_data
Jun 21, 2019
Merged

Adding missing package_data entries#9760
tjprescott merged 5 commits intoAzure:FixTestDiscoveryfrom
marstr:add_package_data

Conversation

@marstr
Copy link
Member

@marstr marstr commented Jun 21, 2019

This was missed during initial migration

@marstr marstr requested a review from tjprescott June 21, 2019 18:00
@marstr marstr changed the title Adding botservice package_data Adding missing package_data entries Jun 21, 2019
@tjprescott tjprescott merged commit 81924fd into Azure:FixTestDiscovery Jun 21, 2019
@marstr
Copy link
Member Author

marstr commented Jun 21, 2019

For posterity, I sped this up significantly by using the following command to help me find all instances of package_data in the former command_module structure:

 git diff azure-cli-2.0.67 upstream/dev -- **setup.py | grep package_data

tjprescott added a commit that referenced this pull request Jun 24, 2019
* Discover tests.

* Debugging

* Fix test discovery

* Re-record tests.

* Re-record tests.

* Adding missing package_data entries (#9760)

* Adding botservice package_data

* Adding core package_data

* Adding acr package_data

* Adding monitor package_data

* Adding servicefabric package_data

* Bump azure-mgmt-authorization SDK version to fix tests.

* Re-record tests and bump azure-mgmt-cosmosdb SDK.

* Remove fuzzy versions.

* Fix version syntax.

* Fix recordings and other test issues.

* Pin requirements.txt for reservations

* Fix AKS tests.

* Re-record tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants