-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ACS] fix orchestrator type comparison in az acs browse
#6405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6405 |
az aks browseaz acs browse
|
Looks like azure-cli master is still broken. Both of my PRs failed with this: Update: never mind, I see #6407. |
Codecov Report
@@ Coverage Diff @@
## dev #6405 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 145 145
Branches 11 11
===================================
Misses 145 145Continue to review full report at Codecov.
|
|
Could this get reviewed soon? I'd like to get this bug fix in the next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type could this orchestrator_type to be? Why does it need to be cast into str first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be an instance of azure.mgmt.containerservice.models.ContainerServiceOrchestratorTypes at runtime, which is just an enum class that can be cast to str but isn't directly comparable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the PR and resolve the conflict.
b4cc6b8 to
5a068ad
Compare
|
Given #6497 I assume I'll have to update HISTORY.rst in this PR before it can be merged. |
|
Once it merge back to the |
|
Resolve the conflict. Wait for the CI to pass. |
az acs browseshould work identically toaz acs kubernetes browsefor an ACS Kubernetes cluster, but was broken due to a case-sensitive string comparison.Closes #6158
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.