Skip to content

Conversation

@mboersma
Copy link
Member

@mboersma mboersma commented Jun 5, 2018

Uses the new v20180331 AKS API and adds arguments to support new AKS GA and preview features: RBAC, VNet customization ("advanced networking"), no SSH key needed, Log Analytics monitoring, HTTP application routing, and Azure AD integration (in preview).

Note that this still includes a temp commit with a private copy of the azure-mgmt-containerservice .whl. I'll need to remove that when it is published to Pypi, before this PR merges.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #6497 into rc38 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           rc38   #6497   +/-   ##
====================================
  Coverage     0%      0%           
====================================
  Files        11      11           
  Lines       133     133           
  Branches      9       9           
====================================
  Misses      133     133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9d542...452146e. Read the comment docs.

@troydai troydai self-assigned this Jun 5, 2018
@troydai troydai requested review from tjprescott and williexu June 5, 2018 19:57
@troydai
Copy link
Contributor

troydai commented Jun 5, 2018

@mboersma I will put up a do not merge label per the private build. When will the private package be online?

@mboersma
Copy link
Member Author

mboersma commented Jun 5, 2018

When will the private package be online?

I'm not sure yet. Azure/azure-sdk-for-python#2186 is ready to go and I'm asking around to get it published.

Edit: available now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version should be bumped to 2.1.0 as it is GA now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening an issue to track instead of in code TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already tracking this improvement in VSTS and plan to have it implemented for the subsequent CLI release. I can remove the # TDOO: if you prefer but there are several others in this file too.

@mboersma
Copy link
Member Author

mboersma commented Jun 6, 2018

@troydai the .whl is published to pypi and I removed the temp commit. Let me know what other changes you would like to see.

@troydai
Copy link
Contributor

troydai commented Jun 7, 2018

Looks good to me. I'll merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants