Skip to content

[ACS] fix orchestrator type comparison in az acs browse #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troydai merged 3 commits into from
Jun 13, 2018
Merged

[ACS] fix orchestrator type comparison in az acs browse #6405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ae4150
[ACS] fix orchestrator type comparison in `az acs browse`
mboersma May 22, 2018
52de09b
Update HISTORY.rst
mboersma May 22, 2018
a121f81
Merge branch 'dev' into fix-aks-browse
troydai Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/command_modules/azure-cli-acs/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Release History
++++++
* Updated options of `az aks use-dev-spaces` command. Added `--update` support.
* `az aks get-credentials --admin` won't replace the user context in $HOME/.kube/config
* fix `az acs browse` command error

2.1.0
+++++
Expand Down
4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-acs/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ def acs_browse(cmd, client, resource_group, name, disable_browser=False, ssh_key
def _acs_browse_internal(cmd, client, acs_info, resource_group, name, disable_browser, ssh_key_file):
orchestrator_type = acs_info.orchestrator_profile.orchestrator_type # pylint: disable=no-member

if orchestrator_type == 'kubernetes' or \
if str(orchestrator_type).lower() == 'kubernetes' or \
Copy link
Contributor

@troydai troydai Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type could this orchestrator_type to be? Why does it need to be cast into str first?

Copy link
Member Author

@mboersma mboersma Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be an instance of azure.mgmt.containerservice.models.ContainerServiceOrchestratorTypes at runtime, which is just an enum class that can be cast to str but isn't directly comparable.

Copy link
Contributor

@troydai troydai Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

orchestrator_type == ContainerServiceOrchestratorTypes.kubernetes or \
(acs_info.custom_profile and acs_info.custom_profile.orchestrator == 'kubernetes'): # pylint: disable=no-member
return k8s_browse(cmd, client, name, resource_group, disable_browser, ssh_key_file=ssh_key_file)
elif orchestrator_type == 'dcos' or orchestrator_type == ContainerServiceOrchestratorTypes.dcos:
elif str(orchestrator_type).lower() == 'dcos' or orchestrator_type == ContainerServiceOrchestratorTypes.dcos:
return _dcos_browse_internal(acs_info, disable_browser, ssh_key_file)
else:
raise CLIError('Unsupported orchestrator type {} for browse'.format(orchestrator_type))
Expand Down