command: rename 'vm scaleset' to 'vmss' #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/CC: @BurtBiel @tjprescott |
Member
|
|
| self.cmd('network vnet create -n {vnet_name} -g {resource_group} --subnet-name {subnet_name}'.format(vnet_name=vnet_name, resource_group=self.resource_group, subnet_name=subnet_name)) | ||
| self.cmd('network lb create --name {lb_name} -g {resource_group}'.format(lb_name=lb_name, resource_group=self.resource_group)) | ||
| # TODO: scaleset create needs to be fixed after changes were made to LB create. Issue #510 | ||
| #self.cmd('vm scaleset create --image CentOS --os-disk-name {os_disk_name}' |
Contributor
Author
There was a problem hiding this comment.
i didn't write this test, but i will fix this commented testing scenarios in a separate PR
00Kai0
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
* NFSAAS-1708 add initial version of anf cli extension * NFSAAS-1708 lint fixes * NFSAAS-1708 code owner * NFSAAS-1708 update from review comments * NFSAAS-1708 update from review comments * NFSAAS-1708 update with code review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments (Azure#9) * Nfsaas 1708 initial cli extension (Azure#10) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#11) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#13) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#14) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#16) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * Nfsaas 1708 initial cli extension (Azure#17) * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments * NFSAAS-1708 updates from review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per review feedback from scale set service team