Skip to content

Conversation

@derekbekoe
Copy link
Member

No description provided.

@derekbekoe derekbekoe changed the title [Finishes #114038135] JSON format as output with basic table and text format support JSON format as output with basic table and text format support [Finishes #114038135] Feb 24, 2016
yugangw-msft added a commit that referenced this pull request Feb 26, 2016
JSON format as output with basic table and text format support [Finishes #114038135]
@yugangw-msft yugangw-msft merged commit 1b2fb28 into Azure:master Feb 26, 2016
@derekbekoe derekbekoe deleted the feature-output-formats branch February 26, 2016 22:44
derekbekoe pushed a commit that referenced this pull request Feb 7, 2017
* Add batch data plane commands:

-- Add custom commands
-- Add auto execution data plane codes
-- Import mgmt commands experience

* Added file stream support

* bug fixes

* Fixed regex raw strings

* Added support for JSON input

* Custom and type validation (#4)

* Additional validation and parsing

* Some cleanups

* Minor code refinements

* Fix pylint errors and get rid unused codes.

* List and type validation (#5)

* list and type validation

* Remove auth kwargs

* Fixed typo

* clean pylint error and add data plane command test.

* Bug fixes (#6)

* Remove auth kwargs

* Bug fixes

* Fixed kwargs

* Move the update pool command to custom command.

* Add custom commands test cases

* Tests and delete confirmation (#7)

* Added some tests

* Bug fixes

* Added tests to sln

* Delete confirmation

* Some pylint cleanup

* More tests and fixes (#8)

* Fix pylint and test errors.

* Following PEP8 complaint.

* Use this decroator on doc transfer

* Deferred imports for performance (#9)

* streamlined imports

* pylint fixes

* Renamed AzureDataPlaneCommand

* PyLint and PEP8 clean up.

* Use single parameter for storage account id and name.

* Review feedback + help fixes (#10)

* node-user -> node user

* Review feedback

* More feedback fixes

* pep fixes

* fixed underscore

* More touch ups

* Review fixes (#11)

* Command refinements

* More command feedback

* Test fixes

* More tests

* Add enum list for vmsize and thumbprint algorithm.

* Streamlined commands (#13)

* streamlined commands

* Updated tests

* Fixed arg loading test

* Further command refinements (#14)

* support silent args

* Fixed pool error message

* Further command editing

* last fixes

* Fixed tests (#15)

* Change the coding style.
yugangw-msft added a commit to yugangw-msft/azure-cli that referenced this pull request Sep 22, 2017
* wire up the initial zone support work

* add output

* add tests

* disable package verifications
yugangw-msft added a commit that referenced this pull request Sep 22, 2017
* Initial support for VM and single zone VMSS (#14)

* wire up the initial zone support work

* add output

* add tests

* disable package verifications

* use a private copy of network sdk with zone support (#15)

* Support for zoned public IP. Make global zone_type and zones_type. (#16)

* Support for zoned public IP. Make global zone_type and zones_type.

* Code review feedback.

* apply api version range on vm zone test (#19)

* show zone in the table output (#20)

* install: support to build out a msi installer from local sources (#17)

* doc:add command examples using availability zones (#21)

* Installer: build debian bundle from a local clone (#28)

* skip a few expeneive travis builds

* test: update tests to work with new azure-mgmt-compute with zone support

* network: support zone in network lb create (#37)

* VNet peering examples. (#51)

* Add BrazilUS and Dogfood cloud config files. (#50)

* undo all changes specifically for private repository

* fix help per review feedback

* fix lint error

* use newer nrp sdk version
DaeunYim added a commit to DaeunYim/azure-cli that referenced this pull request Sep 10, 2020
sturrent added a commit to sturrent/azure-cli that referenced this pull request Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete Test 1.1 results:

Bug Tracker Updates:
- Added Bug Azure#12: NSGAnalyzer logger parameter inconsistency
- Added Bug Azure#13: Azure CLI logger integration (knack system)
- Added Bug Azure#14: NSG analyzer resource ID parsing failure
- Updated total: 14 bugs found and fixed (100% success rate)

Git Commits Section:
- Documented all 4 Phase 6 commits with details
- Commit fdb423c: Initial 11 bugs fixed
- Commit f19a14a: Documentation created
- Commit 67e64ad: Logger integration fixed
- Commit 2e90460: NSG resource ID parsing fixed

Files Modified Updates:
- Updated to 6 unique files (added base_analyzer.py, dns_analyzer.py)
- Documented line changes: ~141 total modifications
- Added details on logger and NSG parser changes

Test 1.1 Final Status:
- Duration: ~10 seconds (excellent performance)
- Result: PASSED after 14 bug fixes
- Validation: Output matches standalone tool
- NSG findings: sec_close rule detected correctly

Success Criteria Progress:
✅ Critical bugs fixed (14/14)
✅ Output matches standalone tool
✅ Performance excellent (<10s vs 30s target)
✅ Documentation updated

Updated Conclusion:
- Confidence level: 90% (up from 85%)
- All major integration issues resolved
- 7 bug categories documented
- Technical improvements detailed
- Remaining work: 28 tests, 5-8 hours estimated

Next Step: Test 1.2 (--details flag)
sturrent added a commit to sturrent/azure-cli that referenced this pull request Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete Test 1.1 results:

Bug Tracker Updates:
- Added Bug Azure#12: NSGAnalyzer logger parameter inconsistency
- Added Bug Azure#13: Azure CLI logger integration (knack system)
- Added Bug Azure#14: NSG analyzer resource ID parsing failure
- Updated total: 14 bugs found and fixed (100% success rate)

Git Commits Section:
- Documented all 4 Phase 6 commits with details
- Commit fdb423c: Initial 11 bugs fixed
- Commit f19a14a: Documentation created
- Commit 67e64ad: Logger integration fixed
- Commit 2e90460: NSG resource ID parsing fixed

Files Modified Updates:
- Updated to 6 unique files (added base_analyzer.py, dns_analyzer.py)
- Documented line changes: ~141 total modifications
- Added details on logger and NSG parser changes

Test 1.1 Final Status:
- Duration: ~10 seconds (excellent performance)
- Result: PASSED after 14 bug fixes
- Validation: Output matches standalone tool
- NSG findings: sec_close rule detected correctly

Success Criteria Progress:
✅ Critical bugs fixed (14/14)
✅ Output matches standalone tool
✅ Performance excellent (<10s vs 30s target)
✅ Documentation updated

Updated Conclusion:
- Confidence level: 90% (up from 85%)
- All major integration issues resolved
- 7 bug categories documented
- Technical improvements detailed
- Remaining work: 28 tests, 5-8 hours estimated

Next Step: Test 1.2 (--details flag)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants