Factor our service client creation [Finishes #114442535] [Finishes 114106051] [Finishes 114420495] #16
+76
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly action that creates credentials
BurtBiel
changed the title
src/azure/cli/_debug.py
Outdated
|
|
||
| def should_allow_debug_connection(): | ||
| try: | ||
| return bool(os.environ['AllowDebug']) |
Contributor
Author
There was a problem hiding this comment.
use get instead of try catch
change var name
BurtBiel
changed the title
BurtBiel
changed the title
johanste
added a commit
that referenced
this pull request
Feb 26, 2016
Factor our service client creation [Finishes #114442535] [Finishes 114106051] [Finishes 114420495]
yugangw-msft
pushed a commit
to yugangw-msft/azure-cli
that referenced
this pull request
Sep 22, 2017
…zure#16) * Support for zoned public IP. Make global zone_type and zones_type. * Code review feedback.
yugangw-msft
added a commit
that referenced
this pull request
Sep 22, 2017
* Initial support for VM and single zone VMSS (#14) * wire up the initial zone support work * add output * add tests * disable package verifications * use a private copy of network sdk with zone support (#15) * Support for zoned public IP. Make global zone_type and zones_type. (#16) * Support for zoned public IP. Make global zone_type and zones_type. * Code review feedback. * apply api version range on vm zone test (#19) * show zone in the table output (#20) * install: support to build out a msi installer from local sources (#17) * doc:add command examples using availability zones (#21) * Installer: build debian bundle from a local clone (#28) * skip a few expeneive travis builds * test: update tests to work with new azure-mgmt-compute with zone support * network: support zone in network lb create (#37) * VNet peering examples. (#51) * Add BrazilUS and Dogfood cloud config files. (#50) * undo all changes specifically for private repository * fix help per review feedback * fix lint error * use newer nrp sdk version
DaeunYim
added a commit
to DaeunYim/azure-cli
that referenced
this pull request
Sep 12, 2020
Users/rajsell/reset password
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Fixed incorrect method name in orchestrator when calling ConnectivityTester. Error: AttributeError: 'ConnectivityTester' object has no attribute 'run_connectivity_tests' Root cause: orchestrator.py calling connectivity_tester.run_connectivity_tests(resource_group_name) but correct method is test_connectivity(enable_probes=bool) Fix: - Changed method call from run_connectivity_tests() to test_connectivity() - Updated parameter from resource_group_name to enable_probes=True - Matches actual ConnectivityTester API signature Testing: az aks net-diagnostics -n aks-overlay -g aks-overlay-rg --probe-test ✓ Bug Azure#16: Connectivity tester method name mismatch
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete test results for Category 1: Basic Execution Tests. Tests Completed (6/6): - Test 1.1: Basic execution ✅ - Test 1.2: --details flag ✅ - Test 1.3: --json-report flag ✅ - Test 1.4: --probe-test flag ✅ - Test 1.5: Combined flags (--details --json-report) ✅ - Test 1.6: All flags combined ✅ Bug Azure#16 Added: - Connectivity tester method name mismatch - Fixed incorrect method call (run_connectivity_tests → test_connectivity) Updated Statistics: - Total Bugs Found: 16 - Total Bugs Fixed: 16 - Success Rate: 100% - Total Commits: 11 - Category 1: COMPLETE (6/6 tests passed) All basic execution scenarios validated successfully.
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Fixed incorrect method name in orchestrator when calling ConnectivityTester. Error: AttributeError: 'ConnectivityTester' object has no attribute 'run_connectivity_tests' Root cause: orchestrator.py calling connectivity_tester.run_connectivity_tests(resource_group_name) but correct method is test_connectivity(enable_probes=bool) Fix: - Changed method call from run_connectivity_tests() to test_connectivity() - Updated parameter from resource_group_name to enable_probes=True - Matches actual ConnectivityTester API signature Testing: az aks net-diagnostics -n aks-overlay -g aks-overlay-rg --probe-test ✓ Bug Azure#16: Connectivity tester method name mismatch
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Updated PHASE6-PROGRESS.md with complete test results for Category 1: Basic Execution Tests. Tests Completed (6/6): - Test 1.1: Basic execution ✅ - Test 1.2: --details flag ✅ - Test 1.3: --json-report flag ✅ - Test 1.4: --probe-test flag ✅ - Test 1.5: Combined flags (--details --json-report) ✅ - Test 1.6: All flags combined ✅ Bug Azure#16 Added: - Connectivity tester method name mismatch - Fixed incorrect method call (run_connectivity_tests → test_connectivity) Updated Statistics: - Total Bugs Found: 16 - Total Bugs Fixed: 16 - Success Rate: 100% - Total Commits: 11 - Category 1: COMPLETE (6/6 tests passed) All basic execution scenarios validated successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client factory that includes support for Fiddler debugging