{Misc.} Remove more direct calls to msrestazure
#31603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
FumingZhang,
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes remaining direct calls to msrestazure to consolidate usage on the newer azure.mgmt.core.tools and drops an outdated test for MSI authentication.
- Updated resource ID validation import to use azure.mgmt.core.tools.
- Removed legacy test for managed identity user-assigned object ID authentication.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/_validators.py | Updated import for resource ID validation |
| src/azure-cli-core/azure/cli/core/tests/test_profile.py | Removed legacy MSI authentication test |
Comments suppressed due to low confidence (2)
src/azure-cli-core/azure/cli/core/tests/test_profile.py:501
- Ensure that the removal of tests for MSIAuthenticationWrapper does not leave the user-assigned managed identity scenario uncovered; verify alternative tests are in place if applicable.
@mock.patch('azure.cli.core.auth.adal_authentication.MSIAuthenticationWrapper', autospec=True)
src/azure-cli/azure/cli/command_modules/acs/_validators.py:863
- Confirm that the switch from msrestazure to azure.mgmt.core.tools is fully supported in all deployment environments.
from azure.mgmt.core.tools import is_valid_resource_id
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
commented
Jun 5, 2025
| if container_registry_resource_id is None or container_registry_resource_id == '': | ||
| return | ||
| from msrestazure.tools import is_valid_resource_id | ||
| from azure.mgmt.core.tools import is_valid_resource_id |
Member
Author
3 tasks
FumingZhang
approved these changes
Jun 6, 2025
evelyn-ys
approved these changes
Jun 10, 2025
jiasli
commented
Jun 10, 2025
Comment on lines
-507
to
-508
| def test_login_with_mi_user_assigned_object_id(self, create_subscription_client_mock, | ||
| mock_msi_auth): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing Guide
Remove more direct calls to
msrestazurethat are not covered bymsrestazure#29856msrestazuremanaged identity authentication #31577