{Core} Drop msrestazure managed identity authentication
#31577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Account
jiasli
requested review from
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy msrestazure-based managed identity authentication in favor of MSAL across the CLI. Key changes include:
- Deletion of the
adal_authentication.pymodule and associated tests. - Simplification of
login_with_managed_identityandget_raw_tokenin_profile.pyto exclusively use MSAL credentials. - Removal of configuration flags (
use_msal_managed_identity) and telemetry entries for the old flow.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_aad_auth.py | Drop import of MSIAuthenticationWrapper unused after removal |
| src/azure-cli-core/azure/cli/core/tests/test_profile.py | Remove all msrestazure-based MSI tests and rename MSAL tests |
| src/azure-cli-core/azure/cli/core/telemetry.py | Clean up telemetry property and function for MSAL flag |
| src/azure-cli-core/azure/cli/core/auth/adal_authentication.py | Removed entirely (legacy ADAL wrapper) |
| src/azure-cli-core/azure/cli/core/_profile.py | Simplify MSI flows: drop login_with_managed_identity_msrestazure and related branches |
bebound
approved these changes
Jun 5, 2025
evelyn-ys
approved these changes
Jun 5, 2025
Member
|
We can actually merge #31066 together with this PR. But I'm also fine with split PRs |
jiasli
commented
Jun 5, 2025
| from azure.cli.command_modules.appconfig._utils import get_appconfig_data_client | ||
| from azure.cli.core._profile import Profile | ||
| from azure.cli.core.auth.credential_adaptor import CredentialAdaptor | ||
| from azure.cli.core.auth.adal_authentication import MSIAuthenticationWrapper |
Member
Author
There was a problem hiding this comment.
Incorrect test cases using MSIAuthenticationWrapper have been skipped in #31115. @zhoxing-ms
zhoxing-ms
approved these changes
Jun 5, 2025
This was referenced Jun 5, 2025
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az login --identityDescription
Managed identity authentication with MSAL was added in 2.71.0 (#31092) and made the default in 2.73.0 (#25959). No issues have been reported.
This PR removes
msrestazure's managed identity authentication in 2.75.0.The config option
core.use_msal_managed_identityand its telemetry are removed.msrestazurewill be removed by #31066.