[AKS] az aks create/update: Add command to create/update a network isolated cluster
#31095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bingosummer, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter bootstrap_artifact_source |
||
| aks create | cmd aks create added parameter bootstrap_container_registry_resource_id |
||
| aks create | cmd aks create update parameter outbound_type: updated property choices from ['loadBalancer', 'managedNATGateway', 'userAssignedNATGateway', 'userDefinedRouting'] to ['loadBalancer', 'managedNATGateway', 'none', 'userAssignedNATGateway', 'userDefinedRouting'] |
||
| aks update | cmd aks update added parameter bootstrap_artifact_source |
||
| aks update | cmd aks update added parameter bootstrap_container_registry_resource_id |
||
| aks update | cmd aks update update parameter outbound_type: updated property choices from ['loadBalancer', 'managedNATGateway', 'userAssignedNATGateway', 'userDefinedRouting'] to ['loadBalancer', 'managedNATGateway', 'none', 'userAssignedNATGateway', 'userDefinedRouting'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
AllyW,
kairu-ms,
necusjz and
yonzhan
microsoft-github-policy-service
bot
added
the
Network
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Mar 21, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_network_isolated_cluster
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Mar 21, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
BTW, seems a UT test_construct_mc_profile_default failed with error
self.assertEqual(dec_mc_1, ground_truth_mc_1)E AssertionError: <azur[32 chars]_01.models._models_py3.ManagedCluster object at 0x7f30caec7700> != <azur[32 chars]_01.models._models_py3.ManagedCluster object at 0x7f30caec7c70>
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
bingosummer
force-pushed
the
binxi/network-isolated-cluster
branch
2 times, most recently
from
98fd8d2 to
65e35be
Compare
Member
Author
https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=118814558&view=results passed |
bingosummer
force-pushed
the
binxi/network-isolated-cluster
branch
from
65e35be to
4f8e6ff
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…isolated cluster
bingosummer
force-pushed
the
binxi/network-isolated-cluster
branch
from
4f8e6ff to
5bfda73
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Please specify impacted commands/parameters in the title or history notes in future PRs, as they will show up in the release notes. I've helped to modify it for this PR: |
karataliu
approved these changes
Mar 24, 2025
yanzhudd
approved these changes
Mar 24, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Mar 24, 2025
…isolated cluster (Azure#31095)
jiasli
reviewed
Jun 5, 2025
| container_registry_resource_id = namespace.bootstrap_container_registry_resource_id | ||
| if container_registry_resource_id is None or container_registry_resource_id == '': | ||
| return | ||
| from msrestazure.tools import is_valid_resource_id |
Member
There was a problem hiding this comment.
msrestazure is deprecated. This import is migrated to azure.mgmt.core.tools.is_valid_resource_id by #31603.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create/updateDescription
This PR is to add command to create/update a network isolated cluster.
The newly added parameters are bootstrap profile and outbound type none.
bootstrap_artifact_sourcebootstrap_container_registry_resource_idnoneforoutbound_typeTesting Guide
History Notes
[AKS]
az aks create/update: Add--bootstrap-artifact-sourceparameter to configure artifact source when bootstraping the cluster[AKS]
az aks create/update: Add--bootstrap-container-registry-resource-idparameter to configure container registry resource ID[AKS]
az aks create/update: Add new optionnonefor--outbound-typeparameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.