[App Service] Fix #26920: az webapp deployment slot create: Make the created new slot has same VNet integration settings of source slot as Portal behavior
#30836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @madsd, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
madsd
changed the title
az webapp deployment slotcreate clone from prod - Fix #26920
madsd
changed the title
az webapp deployment slotcreate clone from prod - Fix #26920az webapp deployment slot create clone from prod - Fix #26920
madsd
changed the title
az webapp deployment slot create clone from prod - Fix #26920az webapp deployment slot create Fix #26920 (clone from prod)
Contributor
|
Fixes: #26920 |
zhoxing-ms
changed the title
az webapp deployment slot create Fix #26920 (clone from prod)az webapp deployment slot create: make the command consistent with the portal behavior
zhoxing-ms
changed the title
az webapp deployment slot create: make the command consistent with the portal behavioraz webapp deployment slot create: Make the command consistent with the portal behavior
zhoxing-ms
approved these changes
Mar 24, 2025
Member
|
This PR causes CI failure: CI logs#30776 bumped The CI of this PR was run on 2025-02-18 and #30776 was merged on 2025-02-24. As it has been a long time since the CI was run, it should be triggered again before merging. See #28465 |
3 tasks
Member
|
This PR has no description which doesn't comply with our guideline: https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#format-pr-description |
zhoxing-ms
changed the title
az webapp deployment slot create: Make the command consistent with the portal behavioraz webapp deployment slot create: Make the created new slot has the same VNet integration settings as the source slot to keep consistent with Portal behavior
zhoxing-ms
changed the title
az webapp deployment slot create: Make the created new slot has the same VNet integration settings as the source slot to keep consistent with Portal behavioraz webapp deployment slot create: Make the created new slot has the same VNet integration settings as the source slot
zhoxing-ms
changed the title
az webapp deployment slot create: Make the created new slot has the same VNet integration settings as the source slotaz webapp deployment slot create: Make the created new slot has same VNet integration settings of source slot as Portal behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp deployment slot createDescription
Fix issue: #26920
When using the
az webapp deployment slot createcommand to create a new slot, the new slot does not inherit the VNet integration settings from the source slot.However, when creating a new slot using the azure portal, the new slot has the same VNet integration settings as the source slot
So this PR is to make the created new slot has the same VNet integration settings as the source slot to keep consistent with Portal behavior
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.