[App Service] Add support for linux sitecontainers #30776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp create | cmd webapp create added parameter sitecontainers_app |
||
| webapp sitecontainers | sub group webapp sitecontainers added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
sarsharma
changed the title
vijaysaayi
reviewed
Feb 10, 2025
Contributor
kumaramit-msft
left a comment
kumaramit-msft
left a comment
There was a problem hiding this comment.
Can we do these validations too:
- Only one main container should be allowed to be added.
- Target port if provided should be an integer in port range 1-65535
- Environment Value should be an AppSetting ref, so it should exist in site appsettings list.
- Avoid port conflicts in multiple sidecars. Same target port in multiple sidecars should be flagged.
- Check system identity is enabled for site, if auth-type is system identity.
- Check user-assigned managed identity is already added to site and client-id is one among them for MI case.
vijaysaayi
reviewed
Feb 18, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
please fix the CI issues. |
yanzhudd
reviewed
Feb 21, 2025
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30776 in repo Azure/azure-cli |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
please re-recording the yaml file of the failed tests to fix them. |
Contributor
|
please note that Azure CLI will freeze the code on 02/25/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please resolve the comments ASAP, otherwise this PR has to be postponed to next sprint. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Feb 24, 2025
kairu-ms
approved these changes
Feb 24, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp createaz webapp sitecontainers createaz webapp sitecontainers updateaz webapp sitecontainers deleteaz webapp sitecontainers showaz webapp sitecontainers listaz webapp sitecontainers logaz webapp sitecontainers statusDescription
Adding support for sitecontainers commands for azure web apps. Sitecontainers is a new capability supported on linux webapps: https://azure.github.io/AppService/2024/11/08/Global-Availability-Sidecars.html
Testing Guide
Create a new webapp of type=sitecontainers
az webapp create --name {} --resource-group {} --sitecontainers-appCreate Sitecontainers
az webapp sitecontainers create --name {} --resource-group {} --container-name {} --image {} --target-port {}az webapp sitecontainers create --name {} --resource-group {} --sitecontainers-spec-file {}az webapp sitecontainers update --name {} --resource-group {} --container-name {} --image {} --target-port {}az webapp sitecontainers delete --name {} --resource-group {} --container-name {}az webapp sitecontainers show --name {} --resource-group {} --container-name {}az webapp sitecontainers show --name {} --resource-group {}az webapp sitecontainers log --name {} --resource-group {} --container-name {}az webapp sitecontainers status --name {} --resource-group {} --container-name {}History Notes
[App Service]
az webapp sitecontainers: Add new commands for linux web app sitecontainersThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.