[Role] az role assignment list: Add warning for classic administrators retirement
#29404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| role assignment list | cmd role assignment list update parameter include_classic_administrators: added property deprecate_info_target=--include-classic-administrators |
Collaborator
|
Role |
jiasli
commented
Jul 17, 2024
Comment on lines
780
to
782
| [WARNING] Classic administrators will be deprecated on August 31, 2024. | ||
| After August 31, 2024, all classic administrators risk losing access to the subscription. | ||
| Delete Classic Admins who no longer need access or assign an Azure RBAC role for fine-grained access control. |
Member
Author
There was a problem hiding this comment.
This message is copied from Azure Portal's banner (#27199 (comment)). However, the banner cannot render correctly today:
I don't know what is inside that "Learn more" hyperlink.
Member
Author
There was a problem hiding this comment.
I used Inspect tool to find the link to be https://go.microsoft.com/fwlink/?linkid=2238474
jiasli
commented
Jul 17, 2024
| [WARNING] Classic administrators will be deprecated on August 31, 2024. | ||
| After August 31, 2024, all classic administrators risk losing access to the subscription. | ||
| Delete Classic Admins who no longer need access or assign an Azure RBAC role for fine-grained access control. |
Member
Author
There was a problem hiding this comment.
The wording is inconsistent: the full name administrators should be used, instead of admins.
Suggested change
| Delete Classic Admins who no longer need access or assign an Azure RBAC role for fine-grained access control. | |
| Delete classic administrators who no longer need access or assign an Azure RBAC role for fine-grained access control. |
Member
Author
There was a problem hiding this comment.
As discussed, we should use the official name classic administrators.
dcaro
previously approved these changes
Jul 19, 2024
Contributor
dcaro
left a comment
dcaro
left a comment
There was a problem hiding this comment.
One minor suggestion other than that LGTM
jiasli
changed the title
az role assignment list: Add warning for classic administrators retirement
jiasli
commented
Jul 25, 2024
| c.argument('include_classic_administrators', arg_type=get_three_state_flag(), help='list default role assignments for subscription classic administrators, aka co-admins') | ||
| c.argument('include_classic_administrators', arg_type=get_three_state_flag(), | ||
| help='list default role assignments for subscription classic administrators, aka co-admins', | ||
| deprecate_info=c.deprecate(target='--include-classic-administrators')) |
Member
Author
There was a problem hiding this comment.
Without target='--include-classic-administrators', the warning message will be:
Argument 'include_classic_administrators' has been deprecated and will be removed in a future release.
evelyn-ys
approved these changes
Jul 25, 2024
bebound
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role assignment listDescription
This PR makes changes according to #27199.
According to https://azure.microsoft.com/en-us/updates/azure-classic-administrator-roles-are-retiring-on-31-august-2024/, Azure Classic Administrator roles will be retired on 2024-08-31.
Azure CLI should announce this in advance:
Testing Guide