-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Role] az role assignment list: Add upcoming breaking change announcement for --include-classic-administrators
#31048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| role assignment list | cmd role assignment list update parameter include_classic_administrators: removed property deprecate_info_target=--include-classic-administrators |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
||
| from azure.cli.core.breaking_change import register_argument_deprecate | ||
|
|
||
| register_argument_deprecate('role assignment list', '--include-classic-administrators') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I register deprecation for --all, register_argument_deprecate fails: #31047
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work fine after #31057 merged.


az role assignment list: Announce--include-classic-administrators deprecationaz role assignment list: Announce --include-classic-administrators deprecation
az role assignment list: Announce --include-classic-administrators deprecationaz role assignment list: Announce --include-classic-administrators deprecation breaking change
az role assignment list: Announce --include-classic-administrators deprecation breaking changeaz role assignment list: Add upcoming breaking change announcement for --include-classic-administrators
Related command
az role assignment list --include-classic-administratorsDescription
Migrate #29404 to the new breaking change announcement framework: https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md
Testing Guide