Skip to content

[Role] az role assignment list: Add warning for classic administrators retirement #29404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Jul 25, 2024
+21 −2
Merged

[Role] az role assignment list: Add warning for classic administrators retirement #29404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,15 @@
helps['role assignment list'] = """
type: command
short-summary: List role assignments.
long-summary: By default, only assignments scoped to subscription will be displayed. To view assignments scoped by resource or group, use `--all`.
long-summary: >-
By default, only assignments scoped to subscription will be displayed.
To view assignments scoped by resource or group, use `--all`.


[WARNING] Azure classic subscription administrators will be retired on August 31, 2024.
After August 31, 2024, all classic administrators risk losing access to the subscription.
Delete classic administrators who no longer need access or assign an Azure RBAC role for fine-grained access
control. Learn more: https://go.microsoft.com/fwlink/?linkid=2238474
"""

helps['role assignment list-changelogs'] = """
Expand Down
4 changes: 3 additions & 1 deletion src/azure-cli/azure/cli/command_modules/role/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,9 @@ def load_arguments(self, _):
"managed identities. For managed identities use the principal id. For service principals, "
"use the object id and not the app id.")
c.argument('ids', nargs='+', help='space-separated role assignment ids')
c.argument('include_classic_administrators', arg_type=get_three_state_flag(), help='list default role assignments for subscription classic administrators, aka co-admins')
c.argument('include_classic_administrators', arg_type=get_three_state_flag(),
help='list default role assignments for subscription classic administrators, aka co-admins',
deprecate_info=c.deprecate(target='--include-classic-administrators'))
Copy link
Member Author

@jiasli jiasli Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without target='--include-classic-administrators', the warning message will be:

Argument 'include_classic_administrators' has been deprecated and will be removed in a future release.

c.argument('description', is_preview=True, min_api='2020-04-01-preview', help='Description of role assignment.')
c.argument('condition', is_preview=True, min_api='2020-04-01-preview', help='Condition under which the user can be granted permission.')
c.argument('condition_version', is_preview=True, min_api='2020-04-01-preview', help='Version of the condition syntax. If --condition is specified without --condition-version, default to 2.0.')
Expand Down
9 changes: 9 additions & 0 deletions src/azure-cli/azure/cli/command_modules/role/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@
"The output includes credentials that you must protect. Be sure that you do not include these credentials in "
"your code or check the credentials into your source control. For more information, see https://aka.ms/azadsp-cli")

CLASSIC_ADMINISTRATOR_WARNING = (
"Azure classic subscription administrators will be retired on August 31, 2024. "
"After August 31, 2024, all classic administrators risk losing access to the subscription. "
"Delete classic administrators who no longer need access or assign an Azure RBAC role for fine-grained access "
"control. Learn more: https://go.microsoft.com/fwlink/?linkid=2238474")

logger = get_logger(__name__)

# pylint: disable=too-many-lines, protected-access
Expand Down Expand Up @@ -213,6 +219,9 @@ def list_role_assignments(cmd, assignee=None, role=None, resource_group_name=Non
:param include_groups: include extra assignments to the groups of which the user is a
member(transitively).
'''
if include_classic_administrators:
logger.warning(CLASSIC_ADMINISTRATOR_WARNING)

graph_client = _graph_client_factory(cmd.cli_ctx)
authorization_client = _auth_client_factory(cmd.cli_ctx, scope)
assignments_client = authorization_client.role_assignments
Expand Down