Skip to content

{Core} Use semver for azure-mgmt-core #16074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Jan 20, 2021
Merged

{Core} Use semver for azure-mgmt-core #16074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d37bc7
Use semver for azure-sdk package
jonringer Nov 28, 2020
90c6838
Update src/azure-cli-core/setup.py
jiasli Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
'requests~=2.22',
'six~=1.12',
'pkginfo>=1.5.0.1',
'azure-mgmt-core==1.2.1',
Copy link
Member

@jiasli jiasli Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure-mgmt-core was pinned by #15780. @jsntcy, is it necessary that we should pin it?

We does deliver azure-mgmt-core at https://pypi.org/project/azure-mgmt-core/1.2.1/. nixpkgs is not one of our supported delivery platform. @fengzhou-msft

Copy link
Member

@fengzhou-msft fengzhou-msft Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Azure SDKs are in the transition of track 1 to track 2, there may be unexpected breaking changes. To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.

Azure CLI relies on too many Azure SDKs and third-party dependencies, it is strongly recommended to use the all-in-one platform packages or install the wheel package in an isolated python environment.

Copy link
Contributor Author

@jonringer jonringer Nov 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs is not one of our supported delivery platform.

Yes, I maintain azure-cli for nixpkgs / NixOS.

The Azure SDKs are in the transition of track 1 to track 2, there may be unexpected breaking changes. To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.

This should only be done if there's breaking changes between patch versions. Azure sdk doesn't.

it is strongly recommended to use the all-in-one platform packages or install the wheel package in an isolated python environment.

This is what I'm providing for nixpkgs. I already applied the correct patch NixOS/nixpkgs@d03b3c4, I'm just upstreaming the changes so that other azure-cli users can benefit from better dependency management.

To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.

What I'm referring to is https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md#version in which python sdk is guaranteeing not to break downstream packages until the next the next major bump

cc @lmazuel , I no longer work at msft

Copy link
Member

@fengzhou-msft fengzhou-msft Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm referring to is https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md#version in which python sdk is guaranteeing not to break downstream packages until the next the next major bump

It's supposed to be, but not always true when developers are not aware of the breaking changes especially with Track 2 adoption. Add @jsntcy who works with this SDK to evaulate if we're confident to follow semver at this stage.

'azure-mgmt-core>=1.2.0,<2.0.0',
# Dependencies of the vendored subscription SDK
# https://github.com/Azure/azure-sdk-for-python/blob/ab12b048ddf676fe0ccec16b2167117f0609700d/sdk/resources/azure-mgmt-resource/setup.py#L82-L86
'msrest>=0.5.0',
Expand Down