{Core} Use semver for azure-mgmt-core#16074
Conversation
Azure-sdk generally follows semver. No need to pin.
jonringer
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
jiasli and
jsntcy
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution jonringer! We will review the pull request and get back to you soon. |
|
Core |
| 'requests~=2.22', | ||
| 'six~=1.12', | ||
| 'pkginfo>=1.5.0.1', | ||
| 'azure-mgmt-core==1.2.1', |
There was a problem hiding this comment.
azure-mgmt-core was pinned by #15780. @jsntcy, is it necessary that we should pin it?
We does deliver azure-mgmt-core at https://pypi.org/project/azure-mgmt-core/1.2.1/. nixpkgs is not one of our supported delivery platform. @fengzhou-msft
There was a problem hiding this comment.
The Azure SDKs are in the transition of track 1 to track 2, there may be unexpected breaking changes. To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.
Azure CLI relies on too many Azure SDKs and third-party dependencies, it is strongly recommended to use the all-in-one platform packages or install the wheel package in an isolated python environment.
There was a problem hiding this comment.
nixpkgs is not one of our supported delivery platform.
Yes, I maintain azure-cli for nixpkgs / NixOS.
The Azure SDKs are in the transition of track 1 to track 2, there may be unexpected breaking changes. To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.
This should only be done if there's breaking changes between patch versions. Azure sdk doesn't.
it is strongly recommended to use the all-in-one platform packages or install the wheel package in an isolated python environment.
This is what I'm providing for nixpkgs. I already applied the correct patch NixOS/nixpkgs@d03b3c4, I'm just upstreaming the changes so that other azure-cli users can benefit from better dependency management.
To play safe, we pinned the version for the transition period and a version bump even with the micro version needs full live tests.
What I'm referring to is https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md#version in which python sdk is guaranteeing not to break downstream packages until the next the next major bump
cc @lmazuel , I no longer work at msft
There was a problem hiding this comment.
What I'm referring to is https://github.com/Azure/azure-sdk-for-python/blob/master/doc/dev/mgmt/mgmt_release.md#version in which python sdk is guaranteeing not to break downstream packages until the next the next major bump
It's supposed to be, but not always true when developers are not aware of the breaking changes especially with Track 2 adoption. Add @jsntcy who works with this SDK to evaulate if we're confident to follow semver at this stage.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/azure-cli-core/setup.py
Outdated
| 'six~=1.12', | ||
| 'pkginfo>=1.5.0.1', | ||
| 'azure-mgmt-core==1.2.1', | ||
| 'azure-mgmt-core~=1.2', |
There was a problem hiding this comment.
We can at least use azure-mgmt-core~=1.2.1 to get our users unblocked.
There was a problem hiding this comment.
Mgmt SDKs use:
'azure-mgmt-core>=1.2.0,<2.0.0',which is equivalent to
'azure-mgmt-core~=1.2'
5 participants
Description
Trying to package this for nixpkgs, but I get:
when it's being given 1.2.2
Azure-sdk generally follows semver, so no need to pin.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.