[Core] Upgrade azure-mgmt-core to 1.2.1#15780
Merged
Conversation
jsntcy
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom and
jiasli
as code owners
Collaborator
|
Upgrade azure-mgmt-core |
jsntcy
changed the title
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jiasli
reviewed
Nov 6, 2020
| azure-mgmt-core==1.2.0 | ||
| azure-core==1.7.0 | ||
| azure-mgmt-core==1.2.1 | ||
| azure-core==1.8.2 |
Member
There was a problem hiding this comment.
azure-mgmt-core already specifies the dependency on azure-core.
install_requires=[
"azure-core<2.0.0,>=1.9.0",
],Does CLI need to specify it directly?
Member
Author
There was a problem hiding this comment.
Besides azure-mgmt-core, data plane commands use azure.core directly, so we need specify the version for it.
Member
There was a problem hiding this comment.
That makes sense.
azure-mgmt-core 1.2.1 has dependency
"azure-core<2.0.0,>=1.8.2",Make sure this dependency is always satisfied if we bump any libs.
jiasli
approved these changes
Nov 11, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade azure-mgmt-core to 1.2.1 due to codegen's upgrade, see details in #15766
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.