Factor our service client creation [Finishes #114442535] [Finishes 114106051] [Finishes 114420495]

azure-cli.pyproj

@@ -33,6 +33,12 @@
     </Compile>
     <Compile Include="azure\cli\tests\test_profile.py" />
     <Compile Include="azure\cli\_argparse.py" />
+    <Compile Include="azure\cli\commands\_command_creation.py">
+      <SubType>Code</SubType>
+    </Compile>
+    <Compile Include="azure\cli\_debug.py">
+      <SubType>Code</SubType>
+    </Compile>
     <Compile Include="azure\cli\_logging.py" />
     <Compile Include="azure\cli\_profile.py" />
     <Compile Include="azure\cli\_session.py">

src/azure/cli/_debug.py

@@ -0,0 +1,11 @@
+import os  
+
+def allow_debug_connection(client):  
+    if should_allow_debug_connection():  
+        client.config.connection.verify = False  
+
+def should_allow_debug_connection():  
+    try:  
+        return bool(os.environ['AllowDebug'])  
+    except KeyError:   
+        return False  

src/azure/cli/commands/_command_creation.py

@@ -0,0 +1,8 @@
+from .._profile import Profile
+import azure.cli._debug as _debug
+
+def get_service_client(clientType, configType):
+    profile = Profile()
+    client = clientType(configType(*profile.get_login_credentials()))
+    _debug.allow_debug_connection(client)
+    return client

src/azure/cli/commands/login.py

@@ -5,6 +5,7 @@
 from .._profile import Profile
 from .._util import TableOutput
 from ..commands import command, description, option
+import azure.cli._debug as _debug
 
 CLIENT_ID = '04b07795-8ddb-461a-bbee-02f9e1bf7b46'
 
@@ -20,7 +21,7 @@ def login(args, unexpected):
         import getpass
         password = getpass.getpass(_('Password: '))
 
-    credentials = UserPassCredentials(username, password, client_id=CLIENT_ID)
+    credentials = UserPassCredentials(username, password, client_id=CLIENT_ID, verify=_debug.should_allow_debug_connection())
     client = SubscriptionClient(SubscriptionClientConfiguration(credentials))
     subscriptions = client.subscriptions.list()
 

src/azure/cli/commands/storage.py

@@ -1,8 +1,8 @@
 from ..main import SESSION
-from .._logging import logging
+from .._logging import logger
 from .._util import TableOutput
 from ..commands import command, description, option
-from .._profile import Profile
+from ._command_creation import get_service_client
 
 @command('storage account list')
 @description(_('List storage accounts'))
@@ -13,10 +13,7 @@ def list_accounts(args, unexpected):
     from azure.mgmt.storage.models import StorageAccount
     from msrestazure.azure_active_directory import UserPassCredentials
 
-    profile = Profile()
-    smc = StorageManagementClient(StorageManagementClientConfiguration(
-        *profile.get_login_credentials(),
-    ))
+    smc = get_service_client(StorageManagementClient, StorageManagementClientConfiguration)
 
     group = args.get('resource-group')
     if group:
@@ -39,7 +36,7 @@ def list_accounts(args, unexpected):
 def checkname(args, unexpected):
     from azure.mgmt.storage import StorageManagementClient, StorageManagementClientConfiguration
 
-    smc = StorageManagementClient(StorageManagementClientConfiguration())
+    smc = get_service_client(StorageManagementClient, StorageManagementClientConfiguration)
     logger.warn(smc.storage_accounts.check_name_availability(args.account_name))