{Release} Hotfix: TS Multiline String Support for Template Inputs #15759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stamp added to deployment_name, excess file removed in commit, launch,json reverted
…ion_version preview (#15690)
* [Compute] Fix update permission check issue * Fix vmss update instance with image version
… exist ResourceNotFoundError is returned (#15643)
… are incorrect (#15731)
… cosmosdb, dls, hdinsight, policyinsights, iot, role, security, servicefabric (#15710) * fix aks tests * fix advisor * fix appconfig * cognitiveservices * fix cosmosdb * fix dls tests * fix hdinsight * fix policyinsights tests * fix iot tests * fix role tests * fix security tests * clean up resource * fix servicefabric tests * revert domain change
* index.html * history * Commit mode condition * fix date and time * azdev * azdev * module db * db * db * db * db * add retry * retry * revert * Remove iotcentral * Support testing Azure CLI extensions * fix syntax error * log * command order * Improve index.html. Move report link inside table. * Display number of tests in link name. * remove duplicate reports * decrease maxParallel to 5 * Fix a small problem of job condition.
* feat: ephemeral os functionality for aks * fix: unused import * fix: typo
detienne20
changed the title
detienne20
changed the title
detienne20
changed the title
detienne20
changed the title
detienne20
changed the title
Collaborator
|
TS Multiline String Support |
Contributor
|
What is the relationship between this PR and #15760? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customer reported template specs issue (Azure/template-specs#37) where the contents of multiline strings were replaced with #Azure CLI#. This was the result of the _remove_comments_from_json function used to process the template input. This function is typically used in deployments for processing template inputs; multiline strings are processed to prompt for parameters. The full functionality is not needed for creating a template spec from a template input therefore the function has been replaced by process_template_spec in _packing_engine.py.
Example:
Template Input:
{
"variables": {
"myVar": "[if(equals(parameters('kind'), ''),
variables('resources')[variables('provider')][variables('resourceType')],
variables('resources')[variables('provider')][variables('resourceType')][parameters('kind')]))]"
}
}
Template Specs Created:
{
"variables": {
"myVar": "#Azure Cli#"
}
}
Testing Guide
az ts create -g resource_group --name Issue37 -v 1.0 -l westus --template-file original.json
--> Multiline strings starting on lines 2644, 2657, and 2661 should not be replaced by "#Azure CLI#"
-->Can compare template spec created with postTsCreation.json (showcases issue).
Issue37Templates.zip