Skip to content

[Role] az role assignment create: Make description, condition, condition_version preview #15690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiasli merged 2 commits into from
Oct 29, 2020
Merged

[Role] az role assignment create: Make description, condition, condition_version preview #15690

jiasli merged 2 commits into from
Oct 29, 2020

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Oct 28, 2020

Description
Make description, condition, condition_version preview because the public doc is not ready yet.

See email: Detailed document for --condition syntax

Testing Guide

> az role assignment create -h

    --condition         [Preview] : Condition under which the user can be granted
                                    permission.
        Argument '--condition' is in preview. It may be changed/removed in a future
        release.
    --condition-version [Preview] : Version of the condition syntax. If --condition is
                                    specified without --condition-version, default to 2.0.
        Argument '--condition-version' is in preview. It may be changed/removed in a future
        release.
    --description       [Preview] : Description of role assignment.
        Argument '--description' is in preview. It may be changed/removed in a future
        release.

@jiasli jiasli requested review from arrownj and jsntcy as code owners October 28, 2020 02:29
@yonzhan yonzhan added this to the S178 milestone Oct 28, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2020

Role

@yonzhan yonzhan self-requested a review October 28, 2020 04:14
yonzhan
yonzhan approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@yonzhan yonzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiasli jiasli changed the title [Role] Make description, condition, condition_version preview [Role] az role assignment create: Make description, condition, condition_version preview Oct 29, 2020
@jiasli jiasli merged commit 452c022 into Azure:dev Oct 29, 2020
@jiasli jiasli deleted the assignment-preview branch October 29, 2020 03:37
@jiasli jiasli mentioned this pull request Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonzhan yonzhan yonzhan approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy

+1 more reviewer

@arrownj arrownj arrownj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli jiasli

Labels

None yet

Projects

None yet

Milestone

S178

Development

Successfully merging this pull request may close these issues.

3 participants

@jiasli @yonzhan @arrownj