Skip to content

[AKS] add ephemeral os functionality #15673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arrownj merged 3 commits into from
Nov 2, 2020
Merged

[AKS] add ephemeral os functionality #15673

arrownj merged 3 commits into from
Nov 2, 2020

Conversation

@alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented Oct 27, 2020 •
edited
Loading

Description

adds ephemeral os functionality for aks, port of Azure/azure-cli-extensions#2344 from the extension

Testing Guide

samples included in PR

History Notes

[AKS] add ephemeral os functionality

This checklist is used to make sure that common guidelines for a pull request are followed.

@alexeldeib alexeldeib requested a review from arrownj as a code owner October 27, 2020 07:41
@alexeldeib
Copy link
Contributor Author

alexeldeib commented Oct 27, 2020

last failure seems unrelated?

@yungezz yungezz added the AKS az aks/acs/openshift label Oct 27, 2020
@Azure Azure deleted a comment from yonzhan Oct 27, 2020
arrownj
arrownj approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeldeib
Copy link
Contributor Author

alexeldeib commented Oct 29, 2020

@arrownj seems like the ci agent is trying to use make on windows and failing?

File "setup.py", line 159, in run
      raise Exception("ERROR: The 'make' utility is missing from PATH")
  Exception: ERROR: The 'make' utility is missing from PATH

also looks like it's missing openssl?

this pr is code complete for me, just wanted to make sure you weren't waiting.

@arrownj
Copy link
Contributor

arrownj commented Oct 30, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 30, 2020

Azure Pipelines successfully started running 2 pipeline(s).

@arrownj arrownj merged commit 39a2360 into Azure:dev Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arrownj arrownj arrownj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arrownj arrownj

Labels

AKS az aks/acs/openshift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeldeib @arrownj @yungezz