BotService: Sprint 75 #10584
Closed
BotService: Sprint 75 #10584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
commented
Sep 20, 2019
.../botservice/tests/latest/recordings/test_botservice_update_should_update_bot_properties.yaml
Show resolved
Hide resolved
stevengum
changed the title
Collaborator
|
@qwordy please deal with this PR. |
qwordy
reviewed
Oct 17, 2019
| c.argument('password', options_list=['-p', '--password'], help='The Microsoft account (MSA) password for the bot. Used to authorize messages being sent to the bot.') | ||
| c.argument('tags', arg_type=tags_type) | ||
| c.argument('language', options_list=['--lang'], arg_type=get_enum_type(SUPPORTED_LANGUAGES), help='The language to be used to create the bot.', arg_group='Web Bot Specific') | ||
| c.argument('version', options_list=['-v', '--version'], help='The Microsoft Bot Builder SDK version to be used to create the bot', arg_type=get_enum_type(['v4']), arg_group='Web Bot Specific') |
Member
There was a problem hiding this comment.
Is it a breaking change? Be careful with it. How many requests of this parameter?
You can also use deprecate argument.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#deprecating-commands-and-arguments
Add this change to history, and declare breaking change or deprecated
Contributor
Author
There was a problem hiding this comment.
This PR feedback regarding the history still needs to be added into #11318: command module is in preview. We only support v4 bots with the latest change, and use it by default so the flag --version is unnecessary.
qwordy
reviewed
Oct 17, 2019
Contributor
Author
|
Closing in favor of #11318. The PR feedback here will be addressed in the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: microsoft/botbuilder-tools#1198
Fixes: microsoft/botbuilder-tools#1261
Changes:
--icon-urltoaz bot update--versionflag fromaz bot createThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.