Skip to content

Conversation

@stevengum
Copy link
Contributor

@stevengum stevengum commented Aug 6, 2019

  • Remove v3 bot creation support
    • v3 Web App and Function App Bots can no longer be created
    • Left --version flag for future-proofing
  • Rerecord tests

@adewaleo FYI


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@stevengum
Copy link
Contributor Author

@adewaleo, @tjprescott the tests that failed were tests for commands that don't perform any network calls for their success. I added the ResourceGroupPreparer to avoid the "Please run 'az login' to setup account." when I first added the tests which worked until now.

Now that the .yaml files were removed (example test: test_botservice_prepare_deploy_csharp) the error message is reappearing, but locally the test runs successfully in live and "recorded" mode. Do either of you have any workarounds for avoiding this error message?

@stevengum
Copy link
Contributor Author

I added back the recordings that were deleted when I re-recorded the tests, and that caused the build to pass.

@stevengum
Copy link
Contributor Author

stevengum commented Aug 7, 2019

@yugangw-msft could I get a review please? 😄

@yugangw-msft
Copy link
Contributor

Can you please rebase for me to merge?

@stevengum
Copy link
Contributor Author

@yugangw-msft, done! Pending CI

@yugangw-msft yugangw-msft merged commit 11e91f0 into Azure:dev Aug 7, 2019
@stevengum stevengum mentioned this pull request Sep 27, 2019
2 tasks
@stevengum stevengum deleted the s67 branch May 13, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants