[containerapp]az containerapp compose create: Fix environment resource group parsing issue and improve test cases#6807
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
|
containerapp |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
Greedygre
changed the title
az containerapp compose create: Fix environment resource group parsing issue and improve test cases
| rg_name = f'client.env_rg_{TEST_LOCATION}'.lower().replace(" ", "").replace("(", "").replace(")", "") | ||
| env_name = f'env-{TEST_LOCATION}'.lower().replace(" ", "").replace("(", "").replace(")", "") |
There was a problem hiding this comment.
If we run tests in parallel (recording tests and live tests) and different test cases use the same rg_name and env_name, will there be test failures?
There was a problem hiding this comment.
For testing app scenarios, let them use the same env in the same region to test without having to create a new environment every time.
There was a problem hiding this comment.
Different test app has different app name, so they can pass without conflict.
There was a problem hiding this comment.
This will result in a remaining resource group that stores env.
Let's merge this PR first, I will consider deleting the resource group in our custom cleanup script.
…rce group parsing issue and improve test cases (Azure#6807) * add prepare * fix compose create * containerapp tests use same environment * add prepare * fix compose create * add history for fix az containerapp compose creste * tests for containerapp use same env and rerun tests * change to env rg * remove unused import * comment addressed
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp compose create
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.