[containerapp] Fix az containerapp update --secret-volume-mount appending to NoneType object bug#6821
Conversation
|
Hi @smzeng, |
️✔️Azure CLI Extensions Breaking Change Test
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
Greedygre,
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
yanzhudd and
zhoxing-ms
smzeng
changed the title
|
@yonzhan this has been reviewed by the ACA team and ready for review from the CLI team |
src/containerapp/HISTORY.rst
Outdated
| 0.3.41 | ||
| ++++++ | ||
| * 'az containerapp up/create': enable support for no Dockerfile cases with --repo | ||
| * 'az containerapp update': fix bug for mounting secret volumes using --secret-volume-mount |
There was a problem hiding this comment.
please add description in upcoming section.
The version 0.3.41 has been released, you cannot modify it's history section.
|
Recommend PR title:
|
|
As we have the same command and feature in Azure-cli, please fix in https://github.com/Azure/azure-cli/tree/dev/src/azure-cli/azure/cli/command_modules/containerapp too. |
I sadly don't have the ability to change the title and Stacy is OOF, next time though. |
|
Hi @zhoxing-ms |
| @AllowLargeResponse(8192) | ||
| @ResourceGroupPreparer(location="northcentralus") | ||
| def test_container_app_mount_secret_update_e2e(self, resource_group): | ||
| import requests |
There was a problem hiding this comment.
Why is the import requests needed here?
wangzelin007
changed the title
az containerapp update --secret-volume-mount appending to NoneType object bug
…ending to NoneType object bug (Azure#6821) * fix null volumeMounts issue * update test * update history.rst file * Update HISTORY.rst --------- Co-authored-by: Stacy Zeng <stacyzeng@microsoft.com> Co-authored-by: Juan Paniagua <juancpani@gmail.com>
7 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp update
fixes bug for using the update command to mount a secret volume, checks for if volume is null since volume is now a NoneType object and mounts volumeMount as an array
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.