Skip to content

[ContainerApp] az containerapp env: --infrastructure-resource-group#6736

Closed
Juancpani wants to merge 50 commits intoAzure:mainfrom
Juancpani:resource-group-byovnet
Closed

[ContainerApp] az containerapp env: --infrastructure-resource-group#6736
Juancpani wants to merge 50 commits intoAzure:mainfrom
Juancpani:resource-group-byovnet

Conversation

@Juancpani
Copy link
Contributor

@Juancpani Juancpani commented Sep 7, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 7, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter infrastructure_resource_group

@azure-client-tools-bot-prd
Copy link

Hi @Juancpani,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 7, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Juancpani
Copy link
Contributor Author

@yonzhan I see that this wasn't tagged with containerapps, tagging you to make sure that doesn't cause delays.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 13, 2023

Is this PR ready for review?

@Juancpani
Copy link
Contributor Author

Rebase caused unexpected issues, moving over to: #6751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.