[ContainerApp] az containerapp env: --infrastructure-resource-group by Juancpani · Pull Request #6751 · Azure/azure-cli-extensions

Juancpani · 2023-09-13T00:52:59Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

commit c3b4a63 Merge: b8dcb55 b92cd10 Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Sep 12 20:43:07 2023 -0400 Merge branch 'resource-group-byovnet' of https://github.com/Juancpani/azure-cli-extensions into resource-group-byovnet commit b8dcb55 Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Sep 12 20:16:05 2023 -0400 fixed comments, test passed commit 376341f Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:47:19 2023 -0400 Update HISTORY.rst commit d1adfea Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:13:50 2023 -0400 turn to live only commit f04ee80 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:01:42 2023 -0400 added history commit f0133b3 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 14:52:38 2023 -0400 added passing test for new parameter commit 7403185 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:57:04 2023 -0400 added short abbreviation commit 186d207 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:48:00 2023 -0400 static analysis fixes commit b234751 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:21:22 2023 -0400 fix irg validation commit bcca28c Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 12:54:35 2023 -0400 validation added commit 5443fb0 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Sep 7 13:12:13 2023 -0400 added infra rg to all necessary locations commit b92cd10 Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Sep 12 20:16:05 2023 -0400 fixed comments, test passed commit b26ac3e Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:47:19 2023 -0400 Update HISTORY.rst commit 39a5cd7 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:13:50 2023 -0400 turn to live only commit 99ffe33 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 15:01:42 2023 -0400 added history commit 76842e7 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 14:52:38 2023 -0400 added passing test for new parameter commit cd98e94 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:57:04 2023 -0400 added short abbreviation commit 47e6854 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:48:00 2023 -0400 static analysis fixes commit 28855db Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 13:21:22 2023 -0400 fix irg validation commit fcb0518 Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Sep 8 12:54:35 2023 -0400 validation added commit 6ab7869 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Sep 7 13:12:13 2023 -0400 added infra rg to all necessary locations commit 7aa7ec4 Merge: 7864edf 419c252 Author: Juan Paniagua <juancpani@gmail.com> Date: Wed Sep 6 16:05:31 2023 -0400 Merge branch 'Azure:main' into main commit 7864edf Merge: fed8f40 ebbab2f Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Aug 29 12:14:42 2023 -0400 Merge branch 'Azure:main' into main commit fed8f40 Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Aug 8 11:35:15 2023 -0400 recording fix commit 3d7b3f7 Merge: 2bf126f c31b73e Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Aug 8 11:31:24 2023 -0400 Merge branch 'main' of https://github.com/Juancpani/azure-cli-extensions commit 2bf126f Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 13:07:44 2023 -0400 double space fix for statci analysis commit 9b5b3af Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 12:21:40 2023 -0400 working recording for ingress test commit df1b12b Merge: 0f3a727 2f17d29 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 12:16:29 2023 -0400 Merge branch 'main' of https://github.com/Juancpani/azure-cli-extensions commit 0f3a727 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 12:04:40 2023 -0400 history check commit 3e72b72 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 12:02:50 2023 -0400 added insecure flag to existing test commit 25cdbc6 Author: Juan Paniagua <juancpani@gmail.com> Date: Thu Aug 3 12:02:26 2023 -0400 added TCP validation commit 8a9cf9a Author: Juan Paniagua <juancpani@gmail.com> Date: Wed Aug 2 22:33:56 2023 -0400 added validation commit dfa6f87 Merge: 96af66e 639e10f Author: Juan Paniagua <juancpani@gmail.com> Date: Wed Aug 2 21:06:59 2023 -0400 Merge branch 'main' of https://github.com/Juancpani/azure-cli-extensions commit 96af66e Author: Juan Paniagua <juancpani@gmail.com> Date: Fri Jul 28 14:29:44 2023 -0400 added history commit b073579 Author: Juan Paniagua <juancpani@gmail.com> Date: Wed Jul 26 11:25:25 2023 -0400 white space fix commit 70b0925 Author: Juan Paniagua <juancpani@gmail.com> Date: Tue Jul 25 19:46:21 2023 -0400 added insecure ingress flag to create

azure-client-tools-bot-prd · 2023-09-13T00:53:02Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter infrastructure_resource_group

azure-client-tools-bot-prd · 2023-09-13T00:53:05Z

Hi @Juancpani,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2023-09-13T00:53:11Z

Thank you for your contribution! We will review the pull request and get back to you soon.

Greedygre · 2023-09-13T02:08:56Z

Hi @zhoxing-ms @wangzelin007

The Verify Extensions Index check failed, error as following, could you help to handle? Thanks.

======================================================================
FAIL: test_checksums (__main__.TestIndex)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/vss/_work/1/s/./scripts/ci/test_index.py", line 138, in test_checksums
    self.assertEqual(computed_hash, item['sha256Digest'],

src/containerapp/azext_containerapp/containerapp_env_decorator.py

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py

wangzelin007 · 2023-09-13T05:54:42Z

/azp run

azure-pipelines · 2023-09-13T05:54:53Z

Azure Pipelines successfully started running 2 pipeline(s).

src/containerapp/azext_containerapp/containerapp_env_decorator.py

Juancpani · 2023-09-14T17:15:18Z

@zhoxing-ms this is ready for review.

src/containerapp/azext_containerapp/containerapp_env_decorator.py

Greedygre

LGTM. @Juliehzl Could you help to review this PR?

Juliehzl

@Juancpani Please do remember to update test case

Juancpani · 2023-09-18T15:40:32Z

@yanzhudd this one is ready.

Greedygre · 2023-09-18T15:46:03Z

@yanzhudd this one is ready.

@yanzhudd Could you please help to review this PR? BTW, I will release an extension version this week, so this PR no need to update set_up.py.

yanzhudd · 2023-09-19T02:51:27Z

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py

+    @ResourceGroupPreparer(location="eastus")
+    @live_only()  # passes live but hits CannotOverwriteExistingCassetteException when run from recording
+    def test_containerapp_env_infrastructure_rg(self, resource_group):
+        self.cmd('configure --defaults location={}'.format(TEST_LOCATION))


please check if this config would impact other modules.

Hi @yanzhudd
Currently will not impact other modules if run serially.
Will add this fix as core:
{containerapp} add random config directory for test by Greedygre · Pull Request #27382 · Azure/azure-cli (github.com)

azure-client-tools-bot-prd bot added this to the September 2023 (2023-09-26) milestone Sep 13, 2023

Juancpani changed the title ~~Squashed commit of the following:~~ [ContainerApp] az containerapp env: --infrastructure-resource-group Sep 13, 2023

yonzhan requested review from yanzhudd and zhoxing-ms September 13, 2023 01:01

yonzhan assigned zhoxing-ms Sep 13, 2023

Juancpani mentioned this pull request Sep 13, 2023

[ContainerApp] az containerapp env: --infrastructure-resource-group #6736

Closed

3 tasks

reran testing

13b0a75

Juancpani marked this pull request as ready for review September 13, 2023 01:14

Greedygre reviewed Sep 13, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_decorator.py Outdated Show resolved Hide resolved

Greedygre reviewed Sep 13, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_decorator.py Outdated Show resolved Hide resolved

comment changes to construct and validate

ca929aa

Greedygre reviewed Sep 13, 2023

View reviewed changes

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py Show resolved Hide resolved

Juliehzl reviewed Sep 13, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_decorator.py Show resolved Hide resolved

Merge branch 'main' into infra-rg

b130cfb

Juancpani requested review from Greedygre and Juliehzl September 13, 2023 13:16

smzeng approved these changes Sep 13, 2023

View reviewed changes

Greedygre reviewed Sep 15, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_decorator.py Outdated Show resolved Hide resolved

moved get_infrarg

831b885

Juancpani requested a review from Greedygre September 18, 2023 02:13

Greedygre approved these changes Sep 18, 2023

View reviewed changes

Juliehzl approved these changes Sep 18, 2023

View reviewed changes

Merge branch 'main' into infra-rg

1bbd095

yanzhudd reviewed Sep 19, 2023

View reviewed changes

yanzhudd approved these changes Sep 19, 2023

View reviewed changes

yanzhudd merged commit 68830da into Azure:main Sep 19, 2023

Conversation

Juancpani commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Sep 13, 2023

Uh oh!

yonzhan commented Sep 13, 2023

Uh oh!

Greedygre commented Sep 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangzelin007 commented Sep 13, 2023

Uh oh!

azure-pipelines bot commented Sep 13, 2023

Uh oh!

Uh oh!

Juancpani commented Sep 14, 2023

Uh oh!

Uh oh!

Greedygre left a comment

Choose a reason for hiding this comment

Uh oh!

Juliehzl left a comment

Choose a reason for hiding this comment

Uh oh!

Juancpani commented Sep 18, 2023

Uh oh!

Greedygre commented Sep 18, 2023

Uh oh!

yanzhudd Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

Greedygre Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Juancpani commented Sep 13, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 13, 2023 •

edited

Loading