Skip to content

Conversation

@domainname
Copy link
Contributor

@domainname domainname commented Sep 6, 2023

  • Add argument --auto-sync in az spring certificate add.
  • Add new command az spring certificate update to update a certificate.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 6, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd spring certificate add cmd spring certificate add added parameter enable_auto_sync
⚠️ 1001 - CmdAdd spring certificate update cmd spring certificate update added

@azure-client-tools-bot-prd
Copy link

Hi @domainname,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 6, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@domainname domainname changed the title feat(certificate): Add argument --auto-sync in `az spring certifica… [Spring] Add argument --auto-sync in `az spring certifica… Sep 6, 2023
@domainname domainname changed the title [Spring] Add argument --auto-sync in `az spring certifica… [Spring] certificate - Add argument --auto-sync and new command update Sep 7, 2023
@domainname domainname marked this pull request as ready for review September 12, 2023 05:00
@zhoxing-ms zhoxing-ms merged commit 9d3f7e8 into Azure:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants