[AKS PREVIEW]aks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds

[wanlonghenry]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

Hi @wanlonghenry,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

[azure-client-tools-bot-prd]

Hi @wanlonghenry,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[yonzhan]

AKS PREVIEW

[wanlonghenry]

cli change: Azure/azure-cli#26356

[wanlonghenry]

aks enable addons:

[wanlonghenry]

[wanlonghenry]

[wanlonghenry]

[wanlonghenry]

[zhoxing-ms]

Do you want to release a new extension for this PR change? If so, please upgrade the version defined in the setup.py

[FumingZhang]

LGTM

[FumingZhang]

The corresponding change in azure-cli broke some test cases.

• test_aks_create_default_service_with_monitoring_addon
• test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings
• test_aks_create_with_monitoring_aad_auth_msi_with_syslog
• test_aks_create_with_monitoring_aad_auth_uai_with_syslog
• test_aks_create_with_monitoring_legacy_auth
• test_aks_update_to_msi_cluster_with_addons

Queued live test pipeline to verify the change.

[wanlonghenry]

thank you @FumingZhang for this finding! The
test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings
test_aks_create_with_monitoring_aad_auth_msi_with_syslog
test_aks_create_with_monitoring_aad_auth_uai_with_syslog
test_aks_create_with_monitoring_legacy_auth
are related to the case sensitivity of the attribute: useAADAuth. That is only assertion error in test. Will fix the tests.

the test_aks_update_to_msi_cluster_with_addons, test_aks_create_default_service_with_monitoring_addon are related to a corner case where user is using service principle, will address that.

Question to the live test,

1. do you know why it is not added in the checks?
2. are we suggested to run live tests everytime?
3. Do you suggest we removing the liveonly tag for those tests?
   Thank you!

[wanlonghenry]

the above issue fixed in: Azure/azure-cli#26528

[azclibot]

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=58433&view=results