Skip to content

Conversation

@tg123
Copy link

@tg123 tg123 commented Jun 21, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks addon update --addon web_application_routing .....

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @tg123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 21, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from zhoxing-ms June 21, 2023 06:55
@yonzhan yonzhan requested a review from yanzhudd June 21, 2023 06:55
@FumingZhang
Copy link
Member

The issue has been fixed by PR #6512

@FumingZhang FumingZhang closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants