-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] Add options for users to specify guardrails #6235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @NickKeller, |
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test pipeline to verify the newly added test cases.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
|
@NickKeller Could you please resolve these CI issues? |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
@zhoxing-ms These tests don't fail when I run |
|
@NickKeller Could you please try to re-record the test |
|
@zhoxing-ms I'm running it now, but I fail to see how that will help, considering it's a unit test, code of which I did not touch, is failing |
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py:3760: AssertionError
This seems to be some logic issue from the unit testing itself + @FumingZhang help take a look~ |
|
Checked the error, should change |
|
Replaced by PR #6357 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create|update -g <RGNAME> -n <CLUSTERNAME> --guardrails-level Warning --guardrails-version v1.0.0 --guardrails-excluded-ns ns1,ns2 --enable-addons azure-policyGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.