add support for custom pollers and pagers #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
commented
Nov 9, 2020
|
|
||
| :keyword callable cls: A custom type or function that will be passed the direct response | ||
| :return: An iterator like instance of either ProductResult or the result of cls(response) | ||
| :rtype: ~my.custom.aio.AsyncCustomPager[~custompollerpager.models.ProductResult] |
Contributor
Author
There was a problem hiding this comment.
This function has the custom pager. See imports for correct imports
iscai-msft
commented
Nov 9, 2020
| return deserialized | ||
| _get_multiple_pages_lro_initial.metadata = {'url': '/paging/multiple/lro'} # type: ignore | ||
|
|
||
| async def begin_get_multiple_pages_lro( |
Contributor
Author
There was a problem hiding this comment.
this method has custom poller
iscai-msft
commented
Nov 9, 2020
| ) | ||
| get_null_next_link_name_pages.metadata = {'url': '/paging/nullnextlink'} # type: ignore | ||
|
|
||
| def get_single_pages( |
iscai-msft
commented
Nov 9, 2020
| return deserialized | ||
| _get_multiple_pages_lro_initial.metadata = {'url': '/paging/multiple/lro'} # type: ignore | ||
|
|
||
| def begin_get_multiple_pages_lro( |
Contributor
Author
There was a problem hiding this comment.
has custom poller
…into directive_generate_item_paged * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819)
lmazuel
approved these changes
Nov 12, 2020
iscai-msft
added a commit
that referenced
this pull request
Nov 13, 2020
…into paging_separate_operations * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819)
iscai-msft
added a commit
that referenced
this pull request
Nov 23, 2020
…into multiapi_diff_signatures * 'autorestv3' of https://github.com/Azure/autorest.python: (25 commits) Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819) Update package.json Update ChangeLog.md set discriminator value if readonly (#815) regen to get testserver updates (#814) allow services with no operations to generate (#801) Update package.json Update ChangeLog.md set default value for properties if x-ms-client-default set (#798) Update package.json Update ChangeLog.md add support for --python.debugger (#790) ...
iscai-msft
added a commit
that referenced
this pull request
Nov 23, 2020
…into add_typing_imports * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819) Update package.json Update ChangeLog.md set discriminator value if readonly (#815) regen to get testserver updates (#814) allow services with no operations to generate (#801) Update package.json Update ChangeLog.md set default value for properties if x-ms-client-default set (#798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #810