Skip to content

Conversation

@iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Nov 9, 2020

fixes #811

see regen and tests in #816 (did not include in this PR since i didn't want to block this on testserver release)

@iscai-msft iscai-msft requested a review from lmazuel November 9, 2020 16:48
@iscai-msft iscai-msft merged commit 464613c into autorestv3 Nov 9, 2020
@iscai-msft iscai-msft deleted the discriminator_readonly branch November 9, 2020 18:09
iscai-msft added a commit that referenced this pull request Nov 9, 2020
…into discriminator_readonly_tests

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Update package.json
  Update ChangeLog.md
  set discriminator value if readonly (#815)
iscai-msft added a commit that referenced this pull request Nov 10, 2020
…into lro_200

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Update package.json
  Update ChangeLog.md
  set discriminator value if readonly (#815)
  regen to get testserver updates (#814)
iscai-msft added a commit that referenced this pull request Nov 23, 2020
…into multiapi_diff_signatures

* 'autorestv3' of https://github.com/Azure/autorest.python: (25 commits)
  Update package.json
  Update ChangeLog.md
  add support for custom pollers and pagers (#821)
  Update package.json
  Update ChangeLog.md
  include generation and tests for no operations (#802)
  fix lro response setting (#813)
  add tests for empty first page (#824)
  access error model from operation group's model property (#819)
  Update package.json
  Update ChangeLog.md
  set discriminator value if readonly (#815)
  regen to get testserver updates (#814)
  allow services with no operations to generate (#801)
  Update package.json
  Update ChangeLog.md
  set default value for properties if x-ms-client-default set (#798)
  Update package.json
  Update ChangeLog.md
  add support for --python.debugger (#790)
  ...
iscai-msft added a commit that referenced this pull request Nov 23, 2020
…into add_typing_imports

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Update package.json
  Update ChangeLog.md
  add support for custom pollers and pagers (#821)
  Update package.json
  Update ChangeLog.md
  include generation and tests for no operations (#802)
  fix lro response setting (#813)
  add tests for empty first page (#824)
  access error model from operation group's model property (#819)
  Update package.json
  Update ChangeLog.md
  set discriminator value if readonly (#815)
  regen to get testserver updates (#814)
  allow services with no operations to generate (#801)
  Update package.json
  Update ChangeLog.md
  set default value for properties if x-ms-client-default set (#798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If discriminator is readOnly, we don't generate the constant value in the init

3 participants