fix lro response setting #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
commented
Nov 9, 2020
| kwargs.pop('content_type', None) | ||
|
|
||
| def get_long_running_output(pipeline_response): | ||
| response_headers = {} |
Contributor
Author
There was a problem hiding this comment.
I checked out these missing response headers, and I think we were incorrectly generating them in the first place. Basically what happened was that we were setting the 202 response as the final deserialization, when it should've been the 200 response
Contributor
Author
There was a problem hiding this comment.
I've checked all of the response headers where we no longer generate, and this is the case, @lmazuel what're your thoughts? I don't think this is a breaking change since it's really a bug fix, and all of the response headers we exposes before were empty
iscai-msft
commented
Nov 10, 2020
| if len(response_types) > 1: | ||
| responses_with_bodies = [r for r in self.responses if r.has_body] | ||
| response = None | ||
| if len(responses_with_bodies) > 1: |
Contributor
Author
There was a problem hiding this comment.
keep condition # response schemas
…into lro_200 * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md set discriminator value if readonly (#815) regen to get testserver updates (#814)
lmazuel
approved these changes
Nov 11, 2020
…into lro_200 * 'autorestv3' of https://github.com/Azure/autorest.python: add tests for empty first page (#824) access error model from operation group's model property (#819)
iscai-msft
added a commit
that referenced
this pull request
Nov 11, 2020
…into directive_generate_item_paged * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819)
iscai-msft
added a commit
that referenced
this pull request
Nov 13, 2020
…into paging_separate_operations * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819)
iscai-msft
added a commit
that referenced
this pull request
Nov 23, 2020
…into multiapi_diff_signatures * 'autorestv3' of https://github.com/Azure/autorest.python: (25 commits) Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819) Update package.json Update ChangeLog.md set discriminator value if readonly (#815) regen to get testserver updates (#814) allow services with no operations to generate (#801) Update package.json Update ChangeLog.md set default value for properties if x-ms-client-default set (#798) Update package.json Update ChangeLog.md add support for --python.debugger (#790) ...
iscai-msft
added a commit
that referenced
this pull request
Nov 23, 2020
…into add_typing_imports * 'autorestv3' of https://github.com/Azure/autorest.python: Update package.json Update ChangeLog.md add support for custom pollers and pagers (#821) Update package.json Update ChangeLog.md include generation and tests for no operations (#802) fix lro response setting (#813) add tests for empty first page (#824) access error model from operation group's model property (#819) Update package.json Update ChangeLog.md set discriminator value if readonly (#815) regen to get testserver updates (#814) allow services with no operations to generate (#801) Update package.json Update ChangeLog.md set default value for properties if x-ms-client-default set (#798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #812