Merged
Conversation
This was referenced Nov 4, 2024
Merged
Merged
Merged
Merged
Merged
Contributor
Author
Maddiaa0
reviewed
Nov 4, 2024
| "fullpath", | ||
| "fuzzer", | ||
| "fuzzers", | ||
| "Gerousia", |
Maddiaa0
approved these changes
Nov 5, 2024
Member
Maddiaa0
left a comment
Maddiaa0
left a comment
There was a problem hiding this comment.
This has only been in the repo for a couple of weeks i am amazed it was in so many places
aminsammara
approved these changes
Nov 6, 2024
| * Beware that while governance generally do not care about the implementation | ||
| * this implementation will since it is dependent on the sequencer selection. | ||
| * This also means that the implementation here will need to be "updated" if | ||
| * the interfaces of the sequencer selection changes, for exampel going optimistic. |
Contributor
There was a problem hiding this comment.
Suggested change
| * the interfaces of the sequencer selection changes, for exampel going optimistic. | |
| * the interfaces of the sequencer selection changes, for example going optimistic. |
| /** | ||
| * @title CoinIssuer | ||
| * @author Aztec Labs | ||
| * @notice A contract that allow minting of coin at most at a fixed rate |
Contributor
There was a problem hiding this comment.
Suggested change
| * @notice A contract that allow minting of coin at most at a fixed rate | |
| * @notice A contract that allows minting of coins at a maximum fixed rate |
| * @title Governance | ||
| * @author Aztec Labs | ||
| * @notice A contract that implements the governance logic, including proposal creation, voting, and execution | ||
| * A proposal is a payload which returns a list of actions to be executed by the governance, exluding |
Contributor
There was a problem hiding this comment.
Suggested change
| * A proposal is a payload which returns a list of actions to be executed by the governance, exluding | |
| * A proposal is a payload which returns a list of actions to be executed by the governance, excluding |
LHerskind
force-pushed
the
lh/8328-renaming
branch
from
99ab621 to
d2ac711
Compare
LHerskind
force-pushed
the
lh/8328-renaming
branch
from
c17af8e to
9605ee4
Compare
LHerskind
force-pushed
the
lh/8328-renaming
branch
from
9605ee4 to
f952745
Compare
ludamad
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fixes #8328 by using boring names. Ends up with a lot of tiny changes in the form of paths and variable names etc. Some of the environment variable names are changed.  --------- Co-authored-by: just-mitch <68168980+just-mitch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8328 by using boring names.
Ends up with a lot of tiny changes in the form of paths and variable names etc. Some of the environment variable names are changed.