Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
LHerskind
reviewed
Nov 7, 2024
| e2e_token_contract: {} | ||
| e2e_p2p_gossip: | ||
| test_path: 'e2e_p2p/gossip_network.test.ts' | ||
| e2e_p2p_gerousia: |
Contributor
There was a problem hiding this comment.
Oh, this one will likely have a little pain after the renaming from #9725
LHerskind
approved these changes
Nov 7, 2024
Contributor
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
🫡
For the test that is failing, I got some similar results earlier and had to rerun so approving this now.
ludamad
pushed a commit
that referenced
this pull request
Nov 7, 2024
Seeing how these fair with the different test setup, since the gerousia one has been running for a few days Changes: - e2e_p2p was missing from p2p config, so even though above states gerousia was enabled a few days ago, it never actually ran - each e2e_p2p test gets their own runner - labels will now match a prefix in the e2e test config file, rather than being exact, this allows the existing e2e-p2p label to cover all of the new tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing how these fair with the different test setup, since the gerousia one has been running for a few days
Changes: