Conversation
This was referenced Nov 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Contributor
Author
Merged
just-mitch
approved these changes
Nov 4, 2024
just-mitch
approved these changes
Nov 6, 2024
LHerskind
force-pushed
the
lh/8328-renaming
branch
3 times, most recently
from
9605ee4 to
f952745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9362.
The boundary don't support using
type(uint256).max, since the value is a slot and not a timestamp. So when the timestamp is to be computed from the slot we end up multiplying by the slot duration and adding the genesis time (so if slot number is large, it will overflow).slot * slot_duration + genesis_time.Instead, we can do similar to what was done in
pushProposal.t.solfor a computation of the limits. Both are updated to keep it aligned and easier to read.