feat: sequencer checks list of allowed FPCs

[alexghr]

The sequencer now checks the FPC being used by a tx is on its allowlist. This can be specified either by whitelisting contract classes or individual instances.

Fix #5000

[alexghr]

• feat: sequencer checks list of allowed FPCs #5310 👈
• feat: sequencer checks fee balance #5267
• refactor: extract tx validation to separate class #5266
• refactor: add gas portal to l1 contract addresses #5265
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 22.5 (-77%)
• note_trial_decrypting_time_in_ms (64): 111 (+129%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 161c3136 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,852	36,420
l1_rollup_calldata_gas	66,292	239,280	469,104
l1_rollup_execution_gas	648,030	932,198	1,310,404
l2_block_processing_time_in_ms	1,347 (+9%)	4,903 (+6%)	9,313 (+5%)
note_successful_decrypting_time_in_ms	142 (-23%)	505 (+5%)	978 (+7%)
note_trial_decrypting_time_in_ms	49.3 (-44%)	⚠️ 22.5 (-77%)	⚠️ 111 (+129%)
l2_block_building_time_in_ms	17,872 (+4%)	67,468 (+3%)	134,329 (+4%)
l2_block_rollup_simulation_time_in_ms	8,057 (+5%)	28,546 (+4%)	56,270 (+5%)
l2_block_public_tx_process_time_in_ms	9,795 (+3%)	38,867 (+3%)	77,962 (+4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,960 (-2%)	27,506 (-2%)
note_history_successful_decrypting_time_in_ms	1,236 (-5%)	2,404 (-4%)
note_history_trial_decrypting_time_in_ms	85.0 (-18%)	122 (-29%)
node_database_size_in_bytes	18,624,592	35,049,552
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	279	44,366	28,245
private-kernel-ordering	213	52,869	14,327
base-parity	1,846 (+4%)	128	311
base-rollup	711 (+1%)	165,788	925
root-parity	1,493 (-4%)	1,244	311
root-rollup	51.8 (+1%)	4,487	725
private-kernel-inner	640 (+1%)	73,772	28,245
public-kernel-app-logic	425	35,260	28,215
public-kernel-tail	172 (+1%)	40,926	28,215
merge-rollup	8.31 (+1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+2%)	16.0 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.586 (+2%)	0.495 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8 (+2%)	72.7 (+3%)	231 (+5%)	448	885 (+6%)	1,733 (+5%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470 (+2%)	0.449 (+3%)	0.421 (+4%)	0.419	0.419 (+6%)	0.416 (+5%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.9 (+1%)	107 (+3%)	337 (+4%)	660	1,316 (+5%)	2,640 (+5%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479 (+1%)	0.484 (+3%)	0.460 (+4%)	0.455	0.456 (+4%)	0.460 (+5%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,013

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,218 (+2%)	1,747 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	11.1 (-18%)	1,201 (+1%)

[just-mitch]

Is this accidentally duplicated from above?

[just-mitch]

Separately, if the sequencer is configured to expect a fee, shouldn't there always be a teardown? Or does that feel a little heavy-handed?

[alexghr]

I was thinking we could add a SEQ_CHARGE_FEES env var that would control whether the sequencer rejects txs without teardown/fee payment info. We could toggle this in tests through the node.setConfig({ chargeFees: true }) after setup is complete. WDYT?

[PhilWindle]

Can you just check that this works from the command line? When setting up a node in the aztec package.

[alexghr]

The new env vars works correctly but the aztec start sequencer options (e.g. aztec start --sequencer allowedFeePaymentContractClasses=0xabcdef,feeRecipient=0x12345) are not parsed at all so the sequencer gets them as strings instead of addresses/arrays.

This will require a bit of refactoring, I'll open a separate PR with a fix to parse all of the sequenecer's config options.