Skip to content

fix: downgrade IndexOutOfBounds to a warning#5465

Closed
TomAFrench wants to merge 1 commit intomasterfrom
tf/warn-on-index-errors
Closed

fix: downgrade IndexOutOfBounds to a warning#5465
TomAFrench wants to merge 1 commit intomasterfrom
tf/warn-on-index-errors

Conversation

@TomAFrench
Copy link
Member

Description

Problem*

Resolves #5464

Summary*

This test was failing due to the error being found at compile-time and so a compile-time error was returned rather than the expected runtime error. I've then downgraded this error into a warning so that circuit execution can be performed so that the expected error is thrown.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench enabled auto-merge July 10, 2024 09:41
@TomAFrench TomAFrench closed this Jul 10, 2024
auto-merge was automatically disabled July 10, 2024 09:41

Pull request was closed

@TomAFrench TomAFrench deleted the tf/warn-on-index-errors branch July 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACIR gen errors with some kinds of known failing constraints, changing expected errors in tests

1 participant