feat: Add some metaprogramming methods on TypeDefinition#5310
Merged
feat: Add some metaprogramming methods on TypeDefinition#5310
TypeDefinition#5310Conversation
michaeljklein
approved these changes
Jun 24, 2024
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* Fixes an issue in the interpreter where the interpreter would error for member access expressions on tuples. This prevented e.g. `my_tuple.0`. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5285
Summary*
Implements
as_type,generics, andfieldson theTypeDefinitiontype.The
Typetype isn't really supported yet soas_typeandfieldsreturnQuotedtoken streams instead ofTypes for now.Additional Context
A few bugs still need to be fixed after this PR for the vertical slice to work.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.