Skip to content

fix(aztec-nr): warn on unknown note type id in compute_note_hash_and_nullifier#21491

Merged
nventuro merged 1 commit intomerge-train/fairiesfrom
fix/warn-unknown-note-type-id
Mar 13, 2026
Merged

fix(aztec-nr): warn on unknown note type id in compute_note_hash_and_nullifier#21491
nventuro merged 1 commit intomerge-train/fairiesfrom
fix/warn-unknown-note-type-id

Conversation

@nchamo
Copy link
Contributor

@nchamo nchamo commented Mar 13, 2026

Summary

  • Log a warning when _compute_note_hash_and_nullifier encounters an unknown note type id, instead of silently returning None
  • Add test for the unknown note type id case

Fixes F-436

@nchamo nchamo requested a review from nventuro as a code owner March 13, 2026 13:09
@nchamo nchamo self-assigned this Mar 13, 2026
@nchamo nchamo requested a review from mverzilli March 13, 2026 13:09
@nventuro nventuro merged commit 4f66c33 into merge-train/fairies Mar 13, 2026
11 checks passed
@nventuro nventuro deleted the fix/warn-unknown-note-type-id branch March 13, 2026 15:46
@AztecBot
Copy link
Collaborator

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2026
BEGIN_COMMIT_OVERRIDE
feat!: emit anchor block timestamp for offchain messages (#21414)
fix(aztec-nr): warn on unknown note type id in
compute_note_hash_and_nullifier (#21491)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants