feat!: emit anchor block timestamp for offchain messages#21414
Merged
mverzilli merged 5 commits intomerge-train/fairiesfrom Mar 13, 2026
Merged
feat!: emit anchor block timestamp for offchain messages#21414mverzilli merged 5 commits intomerge-train/fairiesfrom
mverzilli merged 5 commits intomerge-train/fairiesfrom
Conversation
mverzilli
changed the title
Contributor
|
I see that you got the failure of BTW not sure why we are getting exit code 2. Was chatting about it with AI here |
Contributor
Author
Sth probably changed in how rollbacks are handled, I tried a fix some minutes ago but it seems it wasn't enough |
nventuro
approved these changes
Mar 12, 2026
noir-projects/aztec-nr/aztec/src/messages/processing/offchain.nr
Outdated
Show resolved
Hide resolved
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
added a commit
that referenced
this pull request
Mar 13, 2026
Accepted new test cases from PR #21414 in batch_call.test.ts.
ludamad
added a commit
that referenced
this pull request
Mar 13, 2026
…1414) (#21483) ## Summary Backport of #21414 to v4-next. Changes offchain messages to track anchor block timestamp for lifecycle management instead of transaction TTL. Adds `anchorBlockTimestamp` field to `OffchainMessage` type and passes it through all code paths that create offchain messages. ## Conflict Resolution Rebased onto latest `backport-to-v4-next-staging` (which now includes the offchain reception backport #20893). Only one conflict remained in `batch_call.test.ts` — accepted the new test cases from the original PR. ## Verification - yarn-project builds successfully - All unit tests pass (`interaction_options.test.ts`, `batch_call.test.ts`) ClaudeBox log: https://claudebox.work/s/f59343e7af96e770?run=2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes offchain messages to track anchor block timestamp for lifecycle management instead of transaction TTL. This gives as an objective point in time to place the emission of offchain messages that is valid for both private and utility methods.
This is in preparation to make utility methods allow emission of offchain messages.
I'm adding a bunch of unit tests to make sure all proper code paths that need to produce offchain messages in Aztec.js and wallet code are exercised. Admittedly, the tests are not as I would want them:
I think this is a symptom of us missing some more abstractions in our JS contract interaction management code, which is out of scope of this PR.
Closes F-423