Conversation
Changes offchain messages to track anchor block timestamp for lifecycle management instead of transaction TTL. This gives as an objective point in time to place the emission of offchain messages that is valid for both private and utility methods. This is in preparation to make utility methods allow emission of offchain messages. I'm adding a bunch of unit tests to make sure all proper code paths that need to produce offchain messages in Aztec.js and wallet code are exercised. Admittedly, the tests are not as I would want them: 1. They rely too much on mocks. 2. There's a lot of repetition. I think this is a symptom of us missing some more abstractions in our JS contract interaction management code, which is out of scope of this PR. Closes F-423
…nullifier (#21491) ## Summary - Log a warning when `_compute_note_hash_and_nullifier` encounters an unknown note type id, instead of silently returning `None` - Add test for the unknown note type id case Fixes F-436
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: emit anchor block timestamp for offchain messages (#21414)
fix(aztec-nr): warn on unknown note type id in compute_note_hash_and_nullifier (#21491)
END_COMMIT_OVERRIDE