fix: search for all note nonces instead of just the one for the note index#21438
Merged
nventuro merged 1 commit intomerge-train/fairiesfrom Mar 12, 2026
Conversation
nventuro
deleted the
nico/f-428-fix-note-discovery-to-try-all-possible-indices-when
branch
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…index (#21438) We now search in all indices instead of just the one for the corresponding note hash.
This was referenced Mar 12, 2026
Closed
AztecBot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…index (#21438) We now search in all indices instead of just the one for the corresponding note hash.
nventuro
added a commit
that referenced
this pull request
Mar 12, 2026
…index (backport #21438) (#21440) ## Summary Backport of #21438 to `v4-next`. Cherry-pick applied cleanly with no conflicts. ## Changes - Search all possible note hash indices for nonces instead of just the one corresponding to the note hash index - Add `bvec_filter` helper for filtering `BoundedVec` - Add tests for misaligned nonces, out-of-bounds indices, and duplicate unique note hashes ClaudeBox log: https://claudebox.work/s/f0603f16b3f1c566?run=1 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Mar 12, 2026
…index (backport #21438) (#21440) ## Summary Backport of #21438 to `v4-next`. Cherry-pick applied cleanly with no conflicts. ## Changes - Search all possible note hash indices for nonces instead of just the one corresponding to the note hash index - Add `bvec_filter` helper for filtering `BoundedVec` - Add tests for misaligned nonces, out-of-bounds indices, and duplicate unique note hashes ClaudeBox log: https://claudebox.work/s/f0603f16b3f1c566?run=1 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
BEGIN_COMMIT_OVERRIDE fix: skip oracle version check for pinned protocol contracts (#21349) fix: not reusing tags of partially reverted txs (#20817) feat: move storage_slot from partial commitment to completion hash (#21351) feat: offchain reception (#20893) fix: handle workspace members in needsRecompile crate collection (#21284) fix(aztec-nr): return Option from decode functions and fix event commitment capacity (#21264) fix: handle bad note lengths on compute_note_hash_and_nullifier (#21271) fix: address review feedback from PRs #21284 and #21237 (#21369) fix: claim contract & improve nullif docs (#21234) feat!: auto-enqueue public init nullifier for contracts with public functions (#20775) fix: search for all note nonces instead of just the one for the note index (#21438) fix: set anvilSlotsInAnEpoch in e2e_offchain_payment to prevent finalization race (#21452) fix: complete legacy oracle mappings for all pinned contracts (#21404) fix: correct inverted constrained encryption check in message delivery (#21399) feat!: improve L2ToL1MessageWitness API (#21231) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now search in all indices instead of just the one for the corresponding note hash.