Skip to content

fix: address review feedback from PRs #21284 and #21237#21369

Merged
benesjan merged 1 commit intomerge-train/fairiesfrom
jan/review-feedback-fixes
Mar 12, 2026
Merged

fix: address review feedback from PRs #21284 and #21237#21369
benesjan merged 1 commit intomerge-train/fairiesfrom
jan/review-feedback-fixes

Conversation

@benesjan
Copy link
Contributor

Summary

Test plan

  • CI should pass — the expected_error file was updated to match the new error message

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@benesjan benesjan requested a review from nventuro as a code owner March 11, 2026 14:56
@benesjan benesjan requested review from nchamo and removed request for nventuro March 11, 2026 14:59
Copy link
Contributor

@nchamo nchamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ❤️

@benesjan benesjan merged commit e31c5f8 into merge-train/fairies Mar 12, 2026
10 checks passed
@benesjan benesjan deleted the jan/review-feedback-fixes branch March 12, 2026 02:18
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2026
BEGIN_COMMIT_OVERRIDE
fix: skip oracle version check for pinned protocol contracts (#21349)
fix: not reusing tags of partially reverted txs (#20817)
feat: move storage_slot from partial commitment to completion hash
(#21351)
feat: offchain reception (#20893)
fix: handle workspace members in needsRecompile crate collection
(#21284)
fix(aztec-nr): return Option from decode functions and fix event
commitment capacity (#21264)
fix: handle bad note lengths on compute_note_hash_and_nullifier (#21271)
fix: address review feedback from PRs #21284 and #21237 (#21369)
fix: claim contract & improve nullif docs (#21234)
feat!: auto-enqueue public init nullifier for contracts with public
functions (#20775)
fix: search for all note nonces instead of just the one for the note
index (#21438)
fix: set anvilSlotsInAnEpoch in e2e_offchain_payment to prevent
finalization race (#21452)
fix: complete legacy oracle mappings for all pinned contracts (#21404)
fix: correct inverted constrained encryption check in message delivery
(#21399)
feat!: improve L2ToL1MessageWitness API (#21231)
END_COMMIT_OVERRIDE
@AztecBot
Copy link
Collaborator

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants