fix: handle workspace members in needsRecompile crate collection

[benesjan]

Summary

• Fix collectCrateDirs to handle Nargo workspace roots (those with [workspace] and members defined)
• Previously, when the root Nargo.toml was a workspace, its member crates were never visited, so path-based dependencies declared in member crates were not tracked for recompilation
• Now workspace members are visited recursively, and their path-based dependencies are followed as expected
• Added a test covering the workspace scenario with members that have path dependencies to external libs

Test plan

• Unit test traverses workspace members and their path dependencies added and passing
• All existing needsRecompile tests continue to pass (15/15)

🤖 Generated with Claude Code

[benesjan]

• feat: asserts that aztec dep version matches cli #21245
• fix: handle workspace members in needsRecompile crate collection #21284 👈 (View in Graphite)
• merge-train/fairies

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nchamo]

Have a small question about members + dependencies and if they can co-exist

[nchamo]

Just curious. Is it possible for a workspace root to have both members and dependencies? If not, could we clarify that in a comment?

[benesjan]

Workspace is a collection of crates and doesn't have its own source code.

I don't think this is the place to explain what is noir workspace.

[nchamo]

Why not? In this code you are assuming that the toml file either has members or dependencies. I'm not saying that you should write a full explanation of how Noir workspaces work, but a one line doc that explains that this is the actual behavior would benefit people not yet familiar with Noir

But feel free to ignore

[nchamo]

Can we make it easier to read like this? And we could do the same with the other definitions above and below

Suggested change

	const testToml = `[package]
	name = "test_test"
	type = "lib"
	[dependencies]
	aztec = { git = "https://github.com/AztecProtocol/aztec-nr", tag = "v5.0.0" }
	ext = { path = "../external_lib" }
	test_contract = { path = "../test_contract" }
	`;
	const testToml = `
	[package]
	name = "test_test"
	type = "lib"
	[dependencies]
	aztec = { git = "https://github.com/AztecProtocol/aztec-nr", tag = "v5.0.0" }
	ext = { path = "../external_lib" }
	test_contract = { path = "../test_contract" }
	`;

[benesjan]

Then the resulting Nargo.toml would start with a new line. I don't think this matters much as it's already not hard to read.